qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
	David Hildenbrand <david@redhat.com>,
	Thomas Huth <thuth@redhat.com>
Cc: qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
	Ido Plat <Ido.Plat@ibm.com>
Subject: Re: [PATCH v2 1/2] target/s390x: Emulate CVDG
Date: Sat, 27 Jan 2024 12:59:10 +1000	[thread overview]
Message-ID: <4d73dc67-d691-4a0c-a7fd-97fece4a46fb@linaro.org> (raw)
In-Reply-To: <20240125123059.220131-2-iii@linux.ibm.com>

On 1/25/24 22:29, Ilya Leoshkevich wrote:
> CVDG is the same as CVD, except that it converts 64 bits into 128,
> rather than 32 into 64. Create a new helper, which uses Int128
> wrappers.
> 
> Reported-by: Ido Plat<Ido.Plat@ibm.com>
> Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com>
> ---
>   target/s390x/helper.h            |  1 +
>   target/s390x/tcg/insn-data.h.inc |  1 +
>   target/s390x/tcg/int_helper.c    | 21 +++++++++++++++++++++
>   target/s390x/tcg/translate.c     |  8 ++++++++
>   4 files changed, 31 insertions(+)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2024-01-27  3:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 12:29 [PATCH v2 0/2] target/s390x: Emulate CVDG Ilya Leoshkevich
2024-01-25 12:29 ` [PATCH v2 1/2] " Ilya Leoshkevich
2024-01-27  2:59   ` Richard Henderson [this message]
2024-01-25 12:29 ` [PATCH v2 2/2] tests/tcg/s390x: Test CONVERT TO DECIMAL Ilya Leoshkevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d73dc67-d691-4a0c-a7fd-97fece4a46fb@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=Ido.Plat@ibm.com \
    --cc=david@redhat.com \
    --cc=iii@linux.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).