Re: [PATCH v3 2/9] hw/hppa/machine: Disable default devices with --nodefaults option

[David Woodhouse <dwmw2@infradead.org>]

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]

On Fri, 2024-01-12 at 11:29 +0100, deller@kernel.org wrote:
> From: Helge Deller <deller@gmx.de>
> 
> Recognize the qemu --nodefaults option, which will disable the
> following default devices on hppa:
> - lsi53c895a SCSI controller,
> - artist graphics card,
> - LASI 82596 NIC,
> - tulip PCI NIC,
> - second serial PCI card,
> - USB OHCI controller.
> 
> Adding this option is very useful to allow manual testing and
> debugging of the other possible devices on the command line.
> 
> Signed-off-by: Helge Deller <deller@gmx.de>

Well, the LASI 82596 hasn't actually been built since 2019, when there
was a typo in the meson conversion and it started to depend on the non-
existent CONFIG_LASI_I82596 option instead of CONFIG_LASI_82596.

But that doesn't really matter because enable_lasi_lan() has been
#defined to zero for hw/hppa/machine.c ever since the LASI support was
first introduced, so nothing ever tries to instantiate one anyway.

As part of the -nic rework¹ I plan to allow the user to explicitly
specify "lasi_82596" as the model if they want one, or else the default
-nic will be a PCI one as it is at the moment. OK?

¹ https://lore.kernel.org/qemu-devel/20240108204909.564514-1-dwmw2@infradead.org/T/

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]