From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: sw@weilnetz.de
Subject: Re: [PATCH v3] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign
Date: Sun, 18 Oct 2020 11:38:06 -0700 [thread overview]
Message-ID: <4d821c01-3dda-7cab-f383-8fd31ba64c92@linaro.org> (raw)
In-Reply-To: <a80c300f-1a78-e3d1-bc28-2380fd4c7c8e@amsat.org>
On 10/18/20 11:34 AM, Philippe Mathieu-Daudé wrote:
>> + g_assert(size != 0);
>
> "The alignment value, which must be an integer power of 2.",
> so maybe:
>
> g_assert(size != 0 && is_power_of_2(alignment));
This is also true of posix_memalign. If we are going to add this, we should
also assert in the other qemu_try_memalign.
r~
prev parent reply other threads:[~2020-10-18 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 16:48 [PATCH v3] util/oslib-win32: Use _aligned_malloc for qemu_try_memalign Richard Henderson
2020-10-18 16:53 ` Stefan Weil
2020-10-18 18:34 ` Philippe Mathieu-Daudé
2020-10-18 18:38 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d821c01-3dda-7cab-f383-8fd31ba64c92@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).