From: John Snow <jsnow@redhat.com>
To: Fam Zheng <famz@redhat.com>,
Ishani Chugh <chugh.ishani@research.iiit.ac.in>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 2/3] backup: Adds Backup Tool
Date: Wed, 13 Sep 2017 16:04:23 -0400 [thread overview]
Message-ID: <4da9f6d9-ef16-cbc6-a1b9-1bf6f3465a6e@redhat.com> (raw)
In-Reply-To: <20170911050200.GB32341@lemon.lan>
On 09/11/2017 01:02 AM, Fam Zheng wrote:
> On Fri, 09/08 22:11, Ishani Chugh wrote:
>> +def build_parser():
>> + backup_tool = BackupTool()
>> + parser = ArgumentParser()
>> + subparsers = parser.add_subparsers(title='Subcommands',
>> + description='Valid Subcommands',
>> + help='Subcommand help')
>> + guest_parser = subparsers.add_parser('guest', help='Manage guest(s)')
>> + guest_subparsers = guest_parser.add_subparsers(title='Guest Subparser')
>> +# Guest list
>
> Odd indentation of comments. Please align the # at 4th colume line other code
> lines. The same to below.
>
Sorry, that's probably my fault based on how I suggested the comments in
the previous email review. (:
Fam is right though, the pythonic way to comment is by aligning the
octothorpe to column 4 instead of leaving it at column 0.
--js
next prev parent reply other threads:[~2017-09-13 20:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 16:41 [Qemu-devel] [PATCH v4 0/3] QEMU Backup Tool Ishani Chugh
2017-09-08 16:41 ` [Qemu-devel] [PATCH v4 1/3] Add manpage for " Ishani Chugh
2017-09-15 19:11 ` John Snow
2017-09-18 21:19 ` Ishani
2017-09-08 16:41 ` [Qemu-devel] [PATCH v4 2/3] backup: Adds " Ishani Chugh
2017-09-11 5:02 ` Fam Zheng
2017-09-13 20:04 ` John Snow [this message]
2017-09-15 19:13 ` John Snow
2017-09-18 21:13 ` Ishani
2017-09-08 16:41 ` [Qemu-devel] [PATCH v4 3/3] Test for full Backup Ishani Chugh
2017-09-13 23:14 ` John Snow
2017-09-12 9:20 ` [Qemu-devel] [PATCH v4 0/3] QEMU Backup Tool Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4da9f6d9-ef16-cbc6-a1b9-1bf6f3465a6e@redhat.com \
--to=jsnow@redhat.com \
--cc=chugh.ishani@research.iiit.ac.in \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).