From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3791EE92FF8 for ; Fri, 6 Oct 2023 08:38:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qogLq-00014x-J3; Fri, 06 Oct 2023 04:38:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qogLp-00014Q-3p for qemu-devel@nongnu.org; Fri, 06 Oct 2023 04:38:25 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qogLm-00027W-HN for qemu-devel@nongnu.org; Fri, 06 Oct 2023 04:38:23 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4064876e8b8so17941335e9.0 for ; Fri, 06 Oct 2023 01:38:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696581501; x=1697186301; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Rl7RKkbxPrXhWX8DAi5EAd6Rwp+p7NxmDjAHdEYvDVY=; b=Pp2RfgbLZwI2sDAgIYvFA3WLtkFKviKxA24P3Zt7EZrE8lrzuQWiaYXWgkpGNFxjRx RcHFrtlrAuf2HyHEAVzD7DYHi2lwryy2UWZeVLb/VbN5bYjQCosesFTJnpzHOzXSDsyM SWTWmy+xA77FV8w6a6CWdM6dsybZz9zWMYXJP+G4RLUDyiBYHDAB/Nnx6LYcVFKzvqsw 8L9YSU7LT/xhhsdFMOjHRaNpAZGME1sQyHPwRsImRSn7xCJGKG8sXkDOOEFjPqQQKu3k zWwRnxKc7t5ihVUfUIsYHH0e/0eX0QKo7UR+5z0Su3DELwbdzUVzV4RyCKthJkGZyHd4 cAeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696581501; x=1697186301; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rl7RKkbxPrXhWX8DAi5EAd6Rwp+p7NxmDjAHdEYvDVY=; b=Ap2gCHsbOLd/H7Qj0ehGHtyoCA2yJKWHfpJ/GuAkWqzfCu8xLXWjgrVK3MoezpgjpV o+6TowSDw4zj2RQ5SyIQBw/vdf8YJuu7gpKdgnL7NJLXjvKnyPRuGfB5ZwwGgEBze+4q Pj7G0vLslRewkwhRHdokvv9/0xrryhzTwmQQELvcYu5K9v9LlL3Nts4syP1pXiYDJgyR FZ9wNe0UEAS53C7I9Zaj0u8lnoGpP97niAR260BoI5lI8jbJvvK2RpPqFdzFVxy/QtmJ Uf3qaSO+vARb3PpUIQFAM01n3sih8X88BYhZrQc+Wai6Zd3cCFGV0XtOftYSDKA3AUKM aTvQ== X-Gm-Message-State: AOJu0YxfEbwW5YXwduTGZ5ugiGo8LwLvHK2yzQMGix0QyD0PQGFviqBa P6+avq/q4TMcc5DXLVsC67vzZw== X-Google-Smtp-Source: AGHT+IFOcSrH6+f1ZCAko+QVls7Lzhb6y/gqNVqzxcV1UB0NonVq7AH8nzde481kt4WU6Q+I0dhLZA== X-Received: by 2002:adf:f20c:0:b0:320:77f:a982 with SMTP id p12-20020adff20c000000b00320077fa982mr6849400wro.45.1696581500687; Fri, 06 Oct 2023 01:38:20 -0700 (PDT) Received: from [192.168.69.115] ([176.172.115.173]) by smtp.gmail.com with ESMTPSA id e14-20020adffd0e000000b00315af025098sm1126628wrr.46.2023.10.06.01.38.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 01:38:20 -0700 (PDT) Message-ID: <4db7073c-79e5-bb61-13d6-cc17401307b3@linaro.org> Date: Fri, 6 Oct 2023 10:38:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2] pc-bios/meson.build: Silent unuseful DTC warnings Content-Language: en-US To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , qemu-devel@nongnu.org Cc: BALATON Zoltan , Paolo Bonzini , David Gibson , "Edgar E . Iglesias" , qemu-ppc@nongnu.org, Michael Tokarev , Peter Maydell , Alexander Graf , Richard Henderson References: <20231006064750.33852-1-philmd@linaro.org> <9fb5e05e-1772-e21b-0f82-56b4e9135c3b@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -62 X-Spam_score: -6.3 X-Spam_bar: ------ X-Spam_report: (-6.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-4.219, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/10/23 10:32, Cédric Le Goater wrote: > On 10/6/23 10:18, Philippe Mathieu-Daudé wrote: >> On 6/10/23 10:13, Cédric Le Goater wrote: >>> On 10/6/23 08:47, Philippe Mathieu-Daudé wrote: >>>> QEMU consumes some device tree blobs, so these have been committed >>>> to the tree in as firmware, along with the device tree source used >>>> to generate them. We know the blobs are "good enough" to have QEMU >>>> boot a system, so we don't really maintain and rebuild the sources. >>>> >>>> These blobs were generated with older 'dtc' binaries. We use the >>>> v1.6.1 version since 2021 (commit 962fde57b7 "dtc: Update to version >>>> 1.6.1"). >>>> >>>> Since commit 6e0dc9d2a8 ("meson: compile bundled device trees"), >>>> if dtc binary is available, it is directly used to compile the >>>> device tree sources. New versions of 'dtc' add checks which display >>>> warnings or errors. Our sources are a bit old, so dtc v1.6.1 now >>>> emit the following warnings on a fresh build: >>>> >>>>    [163/3414] Generating pc-bios/canyonlands.dts with a custom command >>>>    pc-bios/canyonlands.dts:47.9-50.4: Warning (unit_address_vs_reg): >>>> /memory: node has a reg or ranges property, but no unit name >> ... >> >>>>  From QEMU perspective, these warnings are not really useful. It is >>>> the responsibility of developers adding DT source/blob to QEMU >>>> repository to check the source doesn't produce warnings, but as >>>> long as the blob is useful enough, QEMU can consume it. So these >>>> warnings don't add any value, instead they are noisy and might >>>> distract us to focus on important warnings. Better disable them. >>>> >>>> 'dtc' provides the '--quiet' option for that: >>>> >>>>    $ dtc --help >>>>    Usage: dtc [options] >>>> >>>>    Options: -[qI:O:o:V:d:R:S:p:a:fb:i:H:sW:E:@AThv] >>>>      -q, --quiet >>>>            Quiet: -q suppress warnings, -qq errors, -qqq all >>>> >>>> Update meson to disable these unuseful DTC warnings. >>> >>> >>> Why not try fixing the .dts instead ? These still exist under Linux : >>> >>>    ./arch/powerpc/boot/dts/canyonlands.dts >>>    ./arch/powerpc/boot/dts/bamboo.dts >> >> Because QEMU != Linux, and there isn't always overlap between >> communities? > > sure but bamboo.dts came from Linux. So this should be safe to update. > Alex Graf did 10 years ago. > > I can not tell for the sam460ex. It is probably safer to keep it as it is. > > Sweeping dtc warnings under the rug for all .dts doesn't seem a good idea. > Should we get rid of the .dts and only keep the .dtb then ? I *think* QEMU should generate DT blob with the qemu_fdt API (see "sysemu/device_tree.h") with all the devices emulated, not forward a Linux one.