From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Ilya Leoshkevich" <iii@linux.ibm.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] linux-user/ppc: Fix sigmask endianness issue in sigreturn
Date: Mon, 21 Oct 2024 02:45:24 -0300 [thread overview]
Message-ID: <4dd04e19-401b-46e7-abcb-67b64a3791bc@linaro.org> (raw)
In-Reply-To: <20241017125811.447961-2-iii@linux.ibm.com>
On 17/10/24 09:54, Ilya Leoshkevich wrote:
> do_setcontext() copies the target sigmask without endianness handling
> and then uses target_to_host_sigset_internal(), which expects a
> byte-swapped one. Use target_to_host_sigset() instead.
These function names are confusing.
> Fixes: bcd4933a23f1 ("linux-user: ppc signal handling")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> linux-user/ppc/signal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/ppc/signal.c b/linux-user/ppc/signal.c
> index a1d8c0bccc1..24e5a02a782 100644
> --- a/linux-user/ppc/signal.c
> +++ b/linux-user/ppc/signal.c
> @@ -628,7 +628,7 @@ static int do_setcontext(struct target_ucontext *ucp, CPUPPCState *env, int sig)
> if (!lock_user_struct(VERIFY_READ, mcp, mcp_addr, 1))
> return 1;
>
> - target_to_host_sigset_internal(&blocked, &set);
> + target_to_host_sigset(&blocked, &set);
> set_sigmask(&blocked);
> restore_user_regs(env, mcp, sig);
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2024-10-21 5:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 12:54 [PATCH 0/2] linux-user/ppc: Fix sigmask endianness issue in sigreturn Ilya Leoshkevich
2024-10-17 12:54 ` [PATCH 1/2] " Ilya Leoshkevich
2024-10-20 21:20 ` Richard Henderson
2024-10-21 5:45 ` Philippe Mathieu-Daudé [this message]
2024-10-25 13:53 ` Michael Tokarev
2024-10-25 13:56 ` Ilya Leoshkevich
2024-10-17 12:54 ` [PATCH 2/2] tests/tcg: Test that sigreturn() does not corrupt the signal mask Ilya Leoshkevich
2024-10-22 2:05 ` Richard Henderson
2024-10-22 17:51 ` Richard Henderson
2024-10-22 17:52 ` [PATCH 0/2] linux-user/ppc: Fix sigmask endianness issue in sigreturn Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dd04e19-401b-46e7-abcb-67b64a3791bc@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=iii@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).