From: Richard Henderson <rth@twiddle.net>
To: David Hildenbrand <david@redhat.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cohuck@redhat.com>, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v2 for-2.12 3/5] s390x/tcg: implement SET CLOCK PROGRAMMABLE FIELD
Date: Thu, 7 Dec 2017 16:00:50 -0800 [thread overview]
Message-ID: <4dd3b2a3-854d-303c-d407-f8625b738a3c@twiddle.net> (raw)
In-Reply-To: <20171207153141.15523-4-david@redhat.com>
On 12/07/2017 07:31 AM, David Hildenbrand wrote:
> +DEF_HELPER_FLAGS_1(sckpf, TCG_CALL_NO_RWG, void, env)
...
> +/* Set Tod Programmable Field */
> +void HELPER(sckpf)(CPUS390XState *env)
> +{
> + uint32_t val = env->regs[0];
> +
> + if (val & 0xffff0000) {
> + s390_program_interrupt(env, PGM_SPECIFICATION, 2, GETPC());
> + }
> + env->todpr = val;
> +}
You do read a tcg global -- regs[0]. Either pass in r0 as a parameter or use
TCG_CALL_NO_WG.
r~
next prev parent reply other threads:[~2017-12-08 0:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 15:31 [Qemu-devel] [PATCH v2 for-2.12 0/5] s390x/tcg: CCW hotplug support David Hildenbrand
2017-12-07 15:31 ` [Qemu-devel] [PATCH v2 for-2.12 1/5] s390x/kvm: factor out build_channel_report_mcic() into cpu.h David Hildenbrand
2017-12-08 9:31 ` Cornelia Huck
2017-12-07 15:31 ` [Qemu-devel] [PATCH v2 for-2.12 2/5] s390x/tcg: fix and cleanup mcck injection David Hildenbrand
2017-12-08 9:36 ` Cornelia Huck
2017-12-07 15:31 ` [Qemu-devel] [PATCH v2 for-2.12 3/5] s390x/tcg: implement SET CLOCK PROGRAMMABLE FIELD David Hildenbrand
2017-12-08 0:00 ` Richard Henderson [this message]
2017-12-08 12:44 ` David Hildenbrand
2017-12-07 15:31 ` [Qemu-devel] [PATCH v2 for-2.12 4/5] s390x/tcg: indicate value of TODPR in STCKE David Hildenbrand
2017-12-08 0:02 ` Richard Henderson
2017-12-08 12:45 ` David Hildenbrand
2017-12-08 13:00 ` Christian Borntraeger
2017-12-07 15:31 ` [Qemu-devel] [PATCH v2 for-2.12 5/5] s390x/tcg: wire up STORE CHANNEL REPORT WORD David Hildenbrand
2017-12-08 0:03 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dd3b2a3-854d-303c-d407-f8625b738a3c@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).