qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cleber Rosa <crosa@redhat.com>
To: Anthony PERARD <anthony.perard@citrix.com>, qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
	Eduardo Habkost <ehabkost@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qmp-shell: Fix example with objects as values
Date: Fri, 11 Jan 2019 09:37:47 -0500	[thread overview]
Message-ID: <4de1c9d8-0409-8d79-8839-7ce05e71eff2@redhat.com> (raw)
In-Reply-To: <20190108123311.24456-1-anthony.perard@citrix.com>



On 1/8/19 7:33 AM, Anthony PERARD wrote:
> The example shown that is suppose to let a user passes an object/array as
> argument doesn't work. The quotes get removed by shlex.split() and then
> both JSON parser complains. Fix the example by adding quotes and add
> examples with boolean and array.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  scripts/qmp/qmp-shell | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
> index 770140772d..9937e3c888 100755
> --- a/scripts/qmp/qmp-shell
> +++ b/scripts/qmp/qmp-shell
> @@ -33,7 +33,11 @@
>  # key=value pairs also support Python or JSON object literal subset notations,
>  # without spaces. Dictionaries/objects {} are supported as are arrays [].
>  #
> -#    example-command arg-name1={'key':'value','obj'={'prop':"value"}}

Yes, I can replicate that with a command such as:

(QEMU) object-add qom-type="rng-random" id="rng1" props={"filename":
"/dev/hwrng"}

That results in:

Error while parsing command line: Expected a key=value pair, got
'/dev/hwrng}'
command format: <command-name>  [arg-name1=arg1] ... [arg-nameN=argN]

> +#  JSON:
> +#    example-command arg-name1='{"key":"value","obj":{"prop":"value"}}'
> +#    example-command arg-name1='{"key":"value","obj":[1,true,"three"]}'

The usage fix is to have the dictionary quoted, indeed:

(QEMU) object-add qom-type="rng-random" id="rng4" props="{'filename':
'/dev/hwrng'}"
{"return": {}}

> +#  free style:
> +#    example-command arg-name1="{'key':'value',\"obj\":[1,True,\"three\"]}"
I just find the "free style" confusing... IMO how to be more creative
about escaping is optional, and adds noise to the most common use case.

Thanks,
- Cleber.

>  #
>  # Both JSON and Python formatting should work, including both styles of
>  # string literal quotes. Both paradigms of literal values should work,
> 

-- 
Cleber Rosa
[ Sr Software Engineer - Virtualization Team - Red Hat ]
[ Avocado Test Framework - avocado-framework.github.io ]
[  7ABB 96EB 8B46 B94D 5E0F  E9BB 657E 8D33 A5F2 09F3  ]

  reply	other threads:[~2019-01-11 14:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08 12:33 [Qemu-devel] [PATCH] qmp-shell: Fix example with objects as values Anthony PERARD
2019-01-11 14:37 ` Cleber Rosa [this message]
2019-01-14 17:43   ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4de1c9d8-0409-8d79-8839-7ce05e71eff2@redhat.com \
    --to=crosa@redhat.com \
    --cc=anthony.perard@citrix.com \
    --cc=armbru@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).