From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org
Subject: Re: [PATCH] target/arm: Fix A64 LDRA immediate decode
Date: Mon, 6 Nov 2023 12:59:27 +0100 [thread overview]
Message-ID: <4e080a94-214f-b8b2-6dcc-7b462b028310@linaro.org> (raw)
In-Reply-To: <20231106113445.1163063-1-peter.maydell@linaro.org>
On 6/11/23 12:34, Peter Maydell wrote:
> In commit be23a049 in the conversion to decodetree we broke the
> decoding of the immediate value in the LDRA instruction. This should
> be a 10 bit signed value that is scaled by 8, but in the conversion
> we incorrectly ended up scaling it only by 2. Fix the scaling
> factor.
>
> Cc: qemu-stable@nongnu.org
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1970
> Fixes: be23a049 ("target/arm: Convert load (pointer auth) insns to decodetree")
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> target/arm/tcg/translate.h | 5 +++++
> target/arm/tcg/a64.decode | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-11-06 12:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 11:34 [PATCH] target/arm: Fix A64 LDRA immediate decode Peter Maydell
2023-11-06 11:59 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e080a94-214f-b8b2-6dcc-7b462b028310@linaro.org \
--to=philmd@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).