From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4503ECAC5AA for ; Thu, 25 Sep 2025 08:37:21 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v1hRn-0005s6-Vc; Thu, 25 Sep 2025 04:35:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v1hRj-0005r9-OD for qemu-devel@nongnu.org; Thu, 25 Sep 2025 04:35:23 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v1hRP-0000NW-Iz for qemu-devel@nongnu.org; Thu, 25 Sep 2025 04:35:09 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-46c889b310dso4700795e9.0 for ; Thu, 25 Sep 2025 01:34:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1758789296; x=1759394096; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Kyx8PAMulr6JtWbbO/iZ3MRPGcwo9sej+tWYqV5u/pQ=; b=YXdKFHnPZpOUmbNW/iwmNsFa/kn9vEzbzR+aaCRj+fSAOs+HR1UJKH0pT048q1LG71 pdavfmRn9V/s/Z0Fayf5CmIOai0ufbwh81fO87jCejw/UCNP+ckssixQiLc5u1SAkmYe PZy5djeLwKFY9zM32OP3yuj6LMupBQMjX0drVa2zkSjUNNgr0zea42QxaApdXp0FbEXx ffxJ2KXH+WEosEUxaf+DO8M3D53VSa/FK1Pc28082gtIfYAvhccx13YcaHNdkK8+XxML J2wLqChefGbXyxhu8knmDWrSXJRNEnh/LhkbtYJ4H6L+6KHY3tj2CNdlbdbAKtqINWvD pLnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758789296; x=1759394096; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kyx8PAMulr6JtWbbO/iZ3MRPGcwo9sej+tWYqV5u/pQ=; b=Kzdkp5KEzM9XvoHTI7JXkX2Ewgzde0tVdVADoaFFJQDNAKmnx5sWyzG3DkCmfEZYYY Ai5f4iRyn3vQrr/37WlNKZKFF2EIpuqoEe9rACkPVvQcZpvLPThK0uAx7dpT4s92lgRT +TxYYIpHIPME1WL8nFhYzUlqxsESMFWMgwo0zWjmWOtABe2lAvSWHAZwA56WPzg8bTa6 9CdDR3BQTggFWOmf1ThdLB2fFjkthqsLo0CCDB25w8xtlarwW8RbRrkmAuqvFakndcjM b2peZUMfmiiszlqp7feVdNcRTs7m/2WYHLT3bRVRfnbFb6FC00KdtrHfQ1JW2PIngrks Wshw== X-Gm-Message-State: AOJu0YydS5mBPfX618Dgl/r04yoWctCc3ParXSDw5AGV1Y/gNsA3+EjA TZ+nDJYuTidM93dk+Oe2IjsA0tA+lj7Mz37FK1j3j8xsyJmBT+36zuWe1Zhb1x6A+yWpfZslldH TJW24aVl2PQ== X-Gm-Gg: ASbGncvoy/awku9axvNdOwk3wEXIc0vOjvUmSykeiJpcJzIWpl69LwMLbIwpAZ0KTdI iAROsYS0LrhqfayXtRJQaoWS78Ro3BDuVJ7xOPRLzr9fZ6Mkovo9ytJkngFpoSH+Vc696tCNOi0 zfqdahPeErecDSi+8bG5apDAKCGqjlprOjNoM2uL5/2M9kmZETQv6U5nZU87nlRlwD3p1EevuSt bzLJ8y+s5SCYxIlepO0vbHKAg6vHjOojvDAVF1BluSYawjE3Ovv0Bao0Ckf8o1UEO5vTmz5iXdZ EwSKG6mLUTUNneRnTHXQfoQO03uQ5DsPl2Dmi5mGM9WdJN9EUdtXfTdhVPzm8RLnWguW0hPhhvH on53JUnfUpxklYq0bMlotXxC81HjFzOc4rO2KC24NaO7K7r2LPX6x/d3XtKA4BRoTlw== X-Google-Smtp-Source: AGHT+IFlgO74C2YcG6q5IKTj9eWkg4P1wEhNIYti5paAxgJPjsvqLpBpxGkvuauS+hGqPoIlU6LSBQ== X-Received: by 2002:a05:600c:4ecc:b0:46e:33ed:bca4 with SMTP id 5b1f17b1804b1-46e33edbe6fmr15561145e9.15.1758789295506; Thu, 25 Sep 2025 01:34:55 -0700 (PDT) Received: from [192.168.69.221] (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e33b9e8aesm23277225e9.4.2025.09.25.01.34.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Sep 2025 01:34:54 -0700 (PDT) Message-ID: <4e49f12c-f345-4e8f-95ea-5b5f6fcfede8@linaro.org> Date: Thu, 25 Sep 2025 10:34:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] cpus: Only resume halted CPUs Content-Language: en-US To: qemu-devel@nongnu.org Cc: Phil Dennis-Jordan , Pierrick Bouvier , Mads Ynddal , Alexander Graf , Cameron Esfahani , Richard Henderson , Paolo Bonzini , Peter Maydell , Roman Bolshakov , =?UTF-8?Q?Alex_Benn=C3=A9e?= , qemu-arm@nongnu.org, Manos Pitsidianakis References: <20250925025520.71805-1-philmd@linaro.org> <20250925025520.71805-2-philmd@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: <20250925025520.71805-2-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 25/9/25 04:55, Philippe Mathieu-Daudé wrote: > Avoid kicking running CPUs, trying to resume them. > > Signed-off-by: Philippe Mathieu-Daudé > --- > system/cpus.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/system/cpus.c b/system/cpus.c > index aa7bfcf56e5..6062226d4ac 100644 > --- a/system/cpus.c > +++ b/system/cpus.c > @@ -666,7 +666,9 @@ void resume_all_vcpus(void) > > qemu_clock_enable(QEMU_CLOCK_VIRTUAL, true); > CPU_FOREACH(cpu) { > - cpu_resume(cpu); > + if (cpu->halted) { > + cpu_resume(cpu); > + } > } > } > Please disregard this patch for now, as other changes (non included in this series) are required before this change is correct.