From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QyITe-0008LE-HJ for qemu-devel@nongnu.org; Tue, 30 Aug 2011 03:11:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QyITd-0004zq-92 for qemu-devel@nongnu.org; Tue, 30 Aug 2011 03:11:18 -0400 Message-ID: <4e5c8d01.05cbe30a.22c4.ffffe8ac@mx.google.com> From: Boris Figovsky Date: Tue, 30 Aug 2011 10:00:55 +0300 Subject: [Qemu-devel] [PATCH] x86: fix daa opcode for al register values higher than 0xf9 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org The second if statement should consider the original al register value, and not the new one. Signed-off-by: Boris Figovsky --- target-i386/op_helper.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target-i386/op_helper.c b/target-i386/op_helper.c index 1bbc3b5..1fc248f 100644 --- a/target-i386/op_helper.c +++ b/target-i386/op_helper.c @@ -1970,20 +1970,20 @@ void helper_aas(void) void helper_daa(void) { - int al, af, cf; + int old_al, al, af, cf; int eflags; eflags = helper_cc_compute_all(CC_OP); cf = eflags & CC_C; af = eflags & CC_A; - al = EAX & 0xff; + old_al = al = EAX & 0xff; eflags = 0; if (((al & 0x0f) > 9 ) || af) { al = (al + 6) & 0xff; eflags |= CC_A; } - if ((al > 0x9f) || cf) { + if ((old_al > 0x99) || cf) { al = (al + 0x60) & 0xff; eflags |= CC_C; } -- 1.7.0.4