qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Cédric Le Goater" <clg@kaod.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Markus Armbruster" <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	Daniel Henrique Barboza <danielhb413@gmail.com>,
	Fabiano Rosas <farosas@suse.de>,
	Claudio Fontana <cfontana@suse.de>
Subject: Re: [PATCH 8/9] ppc/pnv: Rephrase error when run with KVM
Date: Tue, 20 Jun 2023 13:31:48 +0200	[thread overview]
Message-ID: <4e6420d8-a39f-a093-b115-f1a107031ec2@linaro.org> (raw)
In-Reply-To: <20230620055911.187065-9-clg@kaod.org>

On 20/6/23 07:59, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   hw/ppc/pnv.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 590fc64b32e9..fc083173f346 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -799,7 +799,8 @@ static void pnv_init(MachineState *machine)
>       DeviceState *dev;
>   
>       if (kvm_enabled()) {
> -        error_report("The powernv machine does not work with KVM acceleration");
> +        error_report("machine %s does not support the KVM accelerator",
> +                     mc->name);
>           exit(EXIT_FAILURE);
>       }
>   

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Now thinking loudly, we could have an array of allowed accelerators
in MachineClass, similarly to allowed_dynamic_sysbus_devices[], then
handle this generically.


  parent reply	other threads:[~2023-06-20 11:32 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20  5:59 [PATCH 0/9] ppc: New reviewers and KVM cleanups Cédric Le Goater
2023-06-20  5:59 ` [PATCH 1/9] MAINTAINERS: Add reviewers for PowerNV baremetal emulation Cédric Le Goater
2023-06-20  7:11   ` Frederic Barrat
2023-06-20  9:11   ` Richard Henderson
2023-06-20  9:40   ` Nicholas Piggin
2023-06-20  5:59 ` [PATCH 2/9] MAINTAINERS: Add reviewer for PowerPC TCG CPUs Cédric Le Goater
2023-06-20  9:11   ` Richard Henderson
2023-06-20  9:40   ` Nicholas Piggin
2023-06-20 10:18   ` Philippe Mathieu-Daudé
2023-06-20  5:59 ` [PATCH 3/9] MAINTAINERS: Add reviewer for XIVE Cédric Le Goater
2023-06-20  7:11   ` Frederic Barrat
2023-06-20  9:11   ` Richard Henderson
2023-06-20  5:59 ` [PATCH 4/9] ppc/prep: Report an error when run with KVM Cédric Le Goater
2023-06-20  9:11   ` Richard Henderson
2023-06-20  5:59 ` [PATCH 5/9] ppc/pegasos2: " Cédric Le Goater
2023-06-20  9:11   ` Richard Henderson
2023-06-20 10:41   ` BALATON Zoltan
2023-06-20  5:59 ` [PATCH 6/9] ppc/sam460ex: " Cédric Le Goater
2023-06-20  9:11   ` Richard Henderson
2023-06-20 10:42   ` BALATON Zoltan
2023-06-20 10:52     ` Cédric Le Goater
2023-06-20 10:56       ` BALATON Zoltan
2023-06-20  5:59 ` [PATCH 7/9] ppc/bamboo: " Cédric Le Goater
2023-06-20  9:11   ` Richard Henderson
2023-06-20  5:59 ` [PATCH 8/9] ppc/pnv: Rephrase " Cédric Le Goater
2023-06-20  9:12   ` Richard Henderson
2023-06-20 11:31   ` Philippe Mathieu-Daudé [this message]
2023-06-20 11:38     ` [SPAM] " Cédric Le Goater
2023-06-20  5:59 ` [PATCH 9/9] target/ppc: Fix timer register accessors when !KVM Cédric Le Goater
2023-06-20  9:10   ` Richard Henderson
2023-06-20 11:53     ` Cédric Le Goater
2023-06-23  9:29 ` [PATCH 0/9] ppc: New reviewers and KVM cleanups Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e6420d8-a39f-a093-b115-f1a107031ec2@linaro.org \
    --to=philmd@linaro.org \
    --cc=armbru@redhat.com \
    --cc=cfontana@suse.de \
    --cc=clg@kaod.org \
    --cc=danielhb413@gmail.com \
    --cc=farosas@suse.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).