From: Cleber Rosa <crosa@redhat.com>
To: Alistair Francis <alistair.francis@xilinx.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, armbru@redhat.com,
crosthwaitepeter@gmail.com, cov@codeaurora.org,
pbonzini@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v6 1/3] loader: Allow ELF loader to auto-detect the ELF arch
Date: Tue, 24 May 2016 19:08:31 -0300 [thread overview]
Message-ID: <4e74e671-96ed-5acf-2c4c-02b7a6bd5a40@redhat.com> (raw)
In-Reply-To: <61ce2ea7fe4c1df986c50fe881c9635ed1ef80fa.1463077144.git.alistair.francis@xilinx.com>
On 05/13/2016 05:37 PM, Alistair Francis wrote:
>
> + if (elf_machine < 1) {
> + /* The caller didn't specify and ARCH, we can figure it out */
Spotted a comment typo: s/and/an/
> + lseek(fd, 0x12, SEEK_SET);
> + if (read(fd, &e_machine, sizeof(e_machine)) != sizeof(e_machine)) {
> + goto fail;
> + }
> + elf_machine = e_machine;
> + }
> +
--
Cleber Rosa
[ Sr Software Engineer - Virtualization Team - Red Hat ]
[ Avocado Test Framework - avocado-framework.github.io ]
next prev parent reply other threads:[~2016-05-24 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 20:37 [Qemu-devel] [PATCH v6 0/3] Add a generic loader Alistair Francis
2016-05-13 20:37 ` [Qemu-devel] [PATCH v6 1/3] loader: Allow ELF loader to auto-detect the ELF arch Alistair Francis
2016-05-24 22:08 ` Cleber Rosa [this message]
2016-05-25 18:22 ` Alistair Francis
2016-05-13 20:37 ` [Qemu-devel] [PATCH v6 2/3] generic-loader: Add a generic loader Alistair Francis
2016-05-13 20:37 ` [Qemu-devel] [PATCH v6 3/3] docs: Add a generic loader explanation document Alistair Francis
2016-05-23 21:41 ` [Qemu-devel] [PATCH v6 0/3] Add a generic loader Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e74e671-96ed-5acf-2c4c-02b7a6bd5a40@redhat.com \
--to=crosa@redhat.com \
--cc=afaerber@suse.de \
--cc=alistair.francis@xilinx.com \
--cc=armbru@redhat.com \
--cc=cov@codeaurora.org \
--cc=crosthwaitepeter@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).