From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5KVG-0002aA-8n for qemu-devel@nongnu.org; Tue, 24 May 2016 18:08:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5KVB-0001oG-Cs for qemu-devel@nongnu.org; Tue, 24 May 2016 18:08:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5KVB-0001o8-6a for qemu-devel@nongnu.org; Tue, 24 May 2016 18:08:37 -0400 References: <61ce2ea7fe4c1df986c50fe881c9635ed1ef80fa.1463077144.git.alistair.francis@xilinx.com> From: Cleber Rosa Message-ID: <4e74e671-96ed-5acf-2c4c-02b7a6bd5a40@redhat.com> Date: Tue, 24 May 2016 19:08:31 -0300 MIME-Version: 1.0 In-Reply-To: <61ce2ea7fe4c1df986c50fe881c9635ed1ef80fa.1463077144.git.alistair.francis@xilinx.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 1/3] loader: Allow ELF loader to auto-detect the ELF arch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, armbru@redhat.com, crosthwaitepeter@gmail.com, cov@codeaurora.org, pbonzini@redhat.com, afaerber@suse.de On 05/13/2016 05:37 PM, Alistair Francis wrote: > > + if (elf_machine < 1) { > + /* The caller didn't specify and ARCH, we can figure it out */ Spotted a comment typo: s/and/an/ > + lseek(fd, 0x12, SEEK_SET); > + if (read(fd, &e_machine, sizeof(e_machine)) != sizeof(e_machine)) { > + goto fail; > + } > + elf_machine = e_machine; > + } > + -- Cleber Rosa [ Sr Software Engineer - Virtualization Team - Red Hat ] [ Avocado Test Framework - avocado-framework.github.io ]