From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
jing2.liu@linux.intel.com, zuban32s@gmail.com
Subject: Re: [PATCH] pci: fix PCI resource reserve capability on BE
Date: Wed, 20 Oct 2021 12:05:38 +0200 [thread overview]
Message-ID: <4e75691f-d40c-3cf3-4e45-2cb71e676581@redhat.com> (raw)
In-Reply-To: <20211020095408.917102-1-mst@redhat.com>
On 10/20/21 11:54, Michael S. Tsirkin wrote:
> PCI resource reserve capability should use LE format as all other PCI
> things. If we don't then seabios won't boot:
>
> === PCI new allocation pass #1 ===
> PCI: check devices
> PCI: QEMU resource reserve cap: size 10000000000000 type io
> PCI: secondary bus 1 size 10000000000000 type io
> PCI: secondary bus 1 size 00200000 type mem
> PCI: secondary bus 1 size 00200000 type prefmem
> === PCI new allocation pass #2 ===
> PCI: out of I/O address space
>
> This became more important since we started reserving IO by default,
> previously no one noticed.
>
> Fixes: e2a6290aab ("hw/pcie-root-port: Fix hotplug for PCI devices requiring IO")
> Cc: marcel.apfelbaum@gmail.com
> Fixes: 226263fb5c ("hw/pci: add QEMU-specific PCI capability to the Generic PCI Express Root Port")
> Cc: zuban32s@gmail.com
> Fixes: 6755e618d0 ("hw/pci: add PCI resource reserve capability to legacy PCI bridge")
> Cc: jing2.liu@linux.intel.com
> Tested-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> hw/pci/pci_bridge.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2021-10-20 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 9:54 [PATCH] pci: fix PCI resource reserve capability on BE Michael S. Tsirkin
2021-10-20 10:05 ` Philippe Mathieu-Daudé [this message]
2021-10-29 8:50 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e75691f-d40c-3cf3-4e45-2cb71e676581@redhat.com \
--to=philmd@redhat.com \
--cc=jing2.liu@linux.intel.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=zuban32s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).