From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F7ABCAC5B0 for ; Mon, 29 Sep 2025 06:31:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v37OX-0000Qr-C3; Mon, 29 Sep 2025 02:29:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v37OU-0000PL-Sl for qemu-devel@nongnu.org; Mon, 29 Sep 2025 02:29:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v37OL-0004uH-N2 for qemu-devel@nongnu.org; Mon, 29 Sep 2025 02:29:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759127373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jmE8PiVYjat4GfDhr1HClOJGhOkrmJabK59uEuCf6DQ=; b=FM9z13Ybo4b7ykcKEdHq3ldXXUmghvr9fQxWuVj8MAVmkzu/77kOawxZC5YVHRQXaEuD/+ h2Rn0PGG9SETWSr8RRGiNd6oxHRCzWqtScXdeZUUhmOPtAy+jFXRCwRD2/OplDpElplIZo fu2HTjUrw0VixrLrirk3/TvftE11L8A= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-W3iKi-F1NZGumvMupMU1xQ-1; Mon, 29 Sep 2025 02:29:31 -0400 X-MC-Unique: W3iKi-F1NZGumvMupMU1xQ-1 X-Mimecast-MFC-AGG-ID: W3iKi-F1NZGumvMupMU1xQ_1759127370 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-aff0df4c4abso437238966b.1 for ; Sun, 28 Sep 2025 23:29:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759127370; x=1759732170; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jmE8PiVYjat4GfDhr1HClOJGhOkrmJabK59uEuCf6DQ=; b=WWhmJFlSiyDPpvPF3kAMJBO6ladlFe5KlFrUXUWNaE7c16y4p+8UxEjF2OlmFyVgln yhG4enF0RHIR8wpCNbeA7WYnMogzGf0bI+UTbSImrlFAWgbbIUPBk/E/F528DkIXkQMx ZXC/tJWOdUfDcNKGYvbcImYCk1vjQMFx5RrcZhfUFHTk6tnuIxxx7pAl5X5vJUb+a9iw PCi6Opz513dlFf0JHIP5S5ufpffiR2s4ar4E4gUAUE5v58cxKfC99r9xArs1P1jbspGA f6lXN/RsTp7EEsUB/SEzDHAG8X5aMdS7FRjTM45iQOHOY11CqTBuqMpVGD+w2sRlzIcM nNPQ== X-Forwarded-Encrypted: i=1; AJvYcCWBhGRb68zxcfVO3SKHPUfVxgmv4zUqZu5TTp48WjrhU5giujRq1LEFwuwDdvpUbVPC7C0VLEXSJLLf@nongnu.org X-Gm-Message-State: AOJu0YxSrals+LUsU+ggfx6L7M1AzuSkf03MmMYslMizHLqLcaC2dlGF gRbjI6YHa1sm7rY2EY7IT3OX7iMgw+4fs1Yhqria5qgdhEs5omvcNSgAUsVSPy5zyMxXbLJwUUk Sh/RSW2O0Dn+tD9E1/Eo8HN5nSIcvd6svoGpYh1QBrzExlDwajE05apwqyCmGS7KjYEA= X-Gm-Gg: ASbGncskLjNa9UU550DGTNUIlaApLu4Hk+QGyYjCMbKuLhauiSj/jeLdHhX4x5FlgS4 TLSt4TbZA3ZzIIcxvZxKu3gavnKhcHixFYaiQj38/otL8JPbTsWCFW4Ckc9cEGTboGICiAyMzL5 h4B1jjou3w9XJzGq6xTJT1DXaOkwPPHvTBynXhrgxReFVl1zLZa0vSqFmXr+o5YQzLGgzx2Gz6p J3kQltClvFimVw3EnXB+2fuwJCZQc/ksAgpaOoXe93okj1hDy2bhHUjFi5LvjVhjotaOp9OmcKt zGgSWzBb2561bhNNAcQKWsWdPHs3kt2UiedD+KsQ3Nd2o/LsOIrx+PnqhQaq2kFuXbo893DUIFa JcJ946w== X-Received: by 2002:a17:907:6d0b:b0:b03:d5ca:b14 with SMTP id a640c23a62f3a-b34beba9670mr1657239866b.61.1759127370374; Sun, 28 Sep 2025 23:29:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHy4GEzBX2q5dEsz6n+BIFN/1WxwneYT3QlfAghgUN4Ty5Hn3AyL9EIPMZj2Wzv6z71m53QPg== X-Received: by 2002:a17:907:6d0b:b0:b03:d5ca:b14 with SMTP id a640c23a62f3a-b34beba9670mr1657237566b.61.1759127369996; Sun, 28 Sep 2025 23:29:29 -0700 (PDT) Received: from [192.168.0.7] (ltea-047-064-114-212.pools.arcor-ip.net. [47.64.114.212]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b35446f758csm862305466b.53.2025.09.28.23.29.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Sep 2025 23:29:29 -0700 (PDT) Message-ID: <4e7f4c36-7bfa-4dcb-971b-cdc98ba92da2@redhat.com> Date: Mon, 29 Sep 2025 08:29:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/9] tests/functional: Re-activate the check-venv target From: Thomas Huth To: Gustavo Romero , qemu-devel@nongnu.org, alex.bennee@linaro.org, berrange@redhat.com Cc: qemu-arm@nongnu.org, manos.pitsidianakis@linaro.org, peter.maydell@linaro.org References: <20250926051542.104432-1-gustavo.romero@linaro.org> <20250926051542.104432-2-gustavo.romero@linaro.org> <5aefdfa3-4b8b-4512-a6a4-1a1684352d0f@redhat.com> <34599995-fe56-436d-82c2-3837037a58a8@linaro.org> <66ea9c0e-14c6-465d-b473-2d750effff4c@redhat.com> Content-Language: en-US Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <66ea9c0e-14c6-465d-b473-2d750effff4c@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.539, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 29/09/2025 08.26, Thomas Huth wrote: > On 26/09/2025 17.43, Gustavo Romero wrote: >> Hi Thomas! >> >> On 9/26/25 05:34, Thomas Huth wrote: >>> On 26/09/2025 07.15, Gustavo Romero wrote: >>>> Add check-venv target as a dependency for the functional tests. This >>>> causes Python modules listed in pythondeps.toml, under the testdeps >>>> group, to be installed when 'make check-functional' is executed to >>>> prepare and run the functional tests. >>>> >>>> Signed-off-by: Gustavo Romero >>>> Suggested-by: Thomas Huth >>>> --- >>>>   tests/Makefile.include | 2 +- >>>>   1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/tests/Makefile.include b/tests/Makefile.include >>>> index 3538c0c740..d012a9b25d 100644 >>>> --- a/tests/Makefile.include >>>> +++ b/tests/Makefile.include >>>> @@ -109,7 +109,7 @@ $(FUNCTIONAL_TARGETS): >>>>       @$(MAKE) SPEED=thorough $(subst -functional,-func,$@) >>>>   .PHONY: check-functional >>>> -check-functional: >>>> +check-functional: check-venv >>> >>> I just noticed that there's still a problem: If you run "make check- >>> functional-aarch64" immediately after configuring + compiling QEMU in a >>> fresh folder for the first time, the functional tests fail with: >>> >>> ModuleNotFoundError: No module named 'pygdbmi' >>> >>> We either need to add dependencies to the check-functional- >>> targets, too, or we have to make sure that tests still get properly >>> skipped in the case that pygdbmi has not been installed into the venv yet. >> >> Isn't it inconsistent that check-functional runs the test and >> check-functional- doesn't? I think it's a good idea to >> skip if the module is not available, yeah, I'll add it in v6, >> but would it be ok to add check-venv to the check-functional- >> targets too? > > I think so... so please try to change this patch to add the "check-venv" > dependency to the "$(FUNCTIONAL_TARGETS):" line instead. Looking at the code twice, I think you need it in addition, not "instead" (since there is no direct dependency from check-functional to the check-functional- targets). Thomas