From: Thomas Huth <thuth@redhat.com>
To: Jason Andryuk <jandryuk@gmail.com>, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Claudio Fontana <cfontana@suse.de>
Subject: Re: [PATCH v2 1/3] accel: Remove _WIN32 ifdef from qtest-cpus.c
Date: Fri, 23 Oct 2020 09:05:59 +0200 [thread overview]
Message-ID: <4ea31bf0-7567-17f9-df16-1f0570afa62a@redhat.com> (raw)
In-Reply-To: <20201013140511.5681-2-jandryuk@gmail.com>
On 13/10/2020 16.05, Jason Andryuk wrote:
> dummy-cpus.c is only compiled with CONFIG_POSIX, so the _WIN32 condition
> will never evaluate true. Remove it.
>
> Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
> ---
> v2: New in v2
> ---
> accel/qtest/qtest-cpus.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/accel/qtest/qtest-cpus.c b/accel/qtest/qtest-cpus.c
> index 7c5399ed9d..db094201c1 100644
> --- a/accel/qtest/qtest-cpus.c
> +++ b/accel/qtest/qtest-cpus.c
> @@ -29,10 +29,6 @@
>
> static void *qtest_cpu_thread_fn(void *arg)
> {
> -#ifdef _WIN32
> - error_report("qtest is not supported under Windows");
> - exit(1);
> -#else
> CPUState *cpu = arg;
> sigset_t waitset;
> int r;
> @@ -69,7 +65,6 @@ static void *qtest_cpu_thread_fn(void *arg)
> qemu_mutex_unlock_iothread();
> rcu_unregister_thread();
> return NULL;
> -#endif
> }
>
> static void qtest_start_vcpu_thread(CPUState *cpu)
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2020-10-23 7:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 14:05 [PATCH v2 0/3] Add Xen CpusAccel Jason Andryuk
2020-10-13 14:05 ` [PATCH v2 1/3] accel: Remove _WIN32 ifdef from qtest-cpus.c Jason Andryuk
2020-10-13 14:06 ` Claudio Fontana
2020-10-23 7:05 ` Thomas Huth [this message]
2020-10-23 8:04 ` Philippe Mathieu-Daudé
2020-10-13 14:05 ` [PATCH v2 2/3] accel: move qtest CpusAccel functions to a common location Jason Andryuk
2020-10-13 14:12 ` Claudio Fontana
2020-10-23 7:07 ` Thomas Huth
2020-10-13 14:05 ` [PATCH v2 3/3] accel: Add xen CpusAccel using dummy-cpus Jason Andryuk
2020-10-13 14:12 ` Claudio Fontana
2020-10-16 15:05 ` Anthony PERARD via
2020-10-13 17:16 ` [PATCH v2 0/3] Add Xen CpusAccel Paolo Bonzini
2020-10-22 15:17 ` Jason Andryuk
2020-10-22 15:29 ` Paolo Bonzini
2020-10-23 7:09 ` Thomas Huth
2020-10-23 9:34 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ea31bf0-7567-17f9-df16-1f0570afa62a@redhat.com \
--to=thuth@redhat.com \
--cc=cfontana@suse.de \
--cc=jandryuk@gmail.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).