From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azoOb-00074a-8V for qemu-devel@nongnu.org; Mon, 09 May 2016 12:51:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azoOY-0007jJ-Pm for qemu-devel@nongnu.org; Mon, 09 May 2016 12:51:00 -0400 References: <1460536389-9161-1-git-send-email-xiecl.fnst@cn.fujitsu.com> <1460536389-9161-3-git-send-email-xiecl.fnst@cn.fujitsu.com> From: Max Reitz Message-ID: <4eb57a6c-f073-2ad6-2128-dff97428ab87@redhat.com> Date: Mon, 9 May 2016 18:50:44 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sBE6RN344iNWR3f9lHrmSUwdeddNWx6kG" Subject: Re: [Qemu-devel] [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , Changlong Xie , qemu devel , Eric Blake , Kevin Wolf , Stefan Hajnoczi Cc: Markus Armbruster , "Dr. David Alan Gilbert" , Dong Eddie , Jiang Yunhong , Wen Congyang , qemu block This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sBE6RN344iNWR3f9lHrmSUwdeddNWx6kG From: Max Reitz To: Alberto Garcia , Changlong Xie , qemu devel , Eric Blake , Kevin Wolf , Stefan Hajnoczi Cc: Markus Armbruster , "Dr. David Alan Gilbert" , Dong Eddie , Jiang Yunhong , Wen Congyang , qemu block Message-ID: <4eb57a6c-f073-2ad6-2128-dff97428ab87@redhat.com> Subject: Re: [PATCH v13 2/3] quorum: implement bdrv_add_child() and bdrv_del_child() References: <1460536389-9161-1-git-send-email-xiecl.fnst@cn.fujitsu.com> <1460536389-9161-3-git-send-email-xiecl.fnst@cn.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 09.05.2016 17:52, Alberto Garcia wrote: > On Wed 13 Apr 2016 10:33:08 AM CEST, Changlong Xie wrote: [...] >> + /* We can safely remove this child now */ >> + memmove(&s->children[i], &s->children[i + 1], >> + (s->num_children - i - 1) * sizeof(BdrvChild *)); >> + s->children =3D g_renew(BdrvChild *, s->children, --s->num_childr= en); >> + bdrv_unref_child(bs, child); >=20 > Question: do we want to decrement last_index if 'i' is the last > children? Something like: I think it's better to keep it consistent. It probably wouldn't hurt to do this, but I don't see any real benefit and on the other hand it looks a bit strange (to the user) to special-case replacement of the last child= =2E Max > if (i =3D=3D s->num_children - 1) { > s->last_index--; > } else { > memmove(...) > } > s->children =3D g_renew(...) >=20 > Berto >=20 --sBE6RN344iNWR3f9lHrmSUwdeddNWx6kG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXML/kAAoJEDuxQgLoOKytjckH/0pmT/s1lKvQg8b+kpgCRZDq cJxr3BFNOMvdTQrpTS6vSZpzR+amMkeMzrRaon4L+BP0RA7naDXD8kaTdkSsjgXZ TJZUwnMG+hLSB0bcgynW9MBgvNaMAEq5YXnnvRTpDxQlt0HMG5s8MJFZpo66giI3 Ptr+l5oGIksxH4dDsgbBFMOUs9Z5/kUtZIDsWVy1HnmFg6C3VnFdp2JQLwX7l8Xl 2gjYGrI04LI+q1Z/2ddMt6vAACTJI+L+jD9lO/sDtOG3lcLcCsMDdhCJ5YH6e3mD hQooyJBmpjYy0d3Uv11cUBVS1RMW+HHjsgBb2w1eGpgcjYgJ3qbQIeReJEj+oTA= =S3He -----END PGP SIGNATURE----- --sBE6RN344iNWR3f9lHrmSUwdeddNWx6kG--