From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F8A4C3DA6E for ; Fri, 5 Jan 2024 22:17:25 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLsV4-0003OP-SO; Fri, 05 Jan 2024 17:17:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLsUr-0003Kf-3B for qemu-devel@nongnu.org; Fri, 05 Jan 2024 17:17:00 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLsUm-0002to-Q6 for qemu-devel@nongnu.org; Fri, 05 Jan 2024 17:16:54 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-40d60ad5f0bso613035e9.0 for ; Fri, 05 Jan 2024 14:16:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704493011; x=1705097811; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4r9F1ve4tri+fejC8d02n5r3ZdvwikIuY6dGBcXdBSI=; b=GiZudMrm4qIKvdCdOaEydHTZPwSQfBhF4PkNwZsFwmeuf4VooZ8E0LOKbYiG8nY9Y7 WRRx841Fdxz2WxjuYzp5phesuCuI//ik+Tu7IQ6LgK09/17CMvveKY3bpj1I5U0Zy9s2 EVU9V4jIP40T/t08X8q+c3/og30ttTBOvflzJlf8Xm7sbktYwIjY9Of0lyvzNhox2yP3 lZXof+4W0S6suGmj0kydJkl3MNySeGZsyrzO77JHd+oqt6USx3SpKONqiJ2zn4LmpBZw 85g5Zl5ZdJ8Kc7KO2yO4Vl1JhS8maEj0K+GbJh93y2EFhLzs3w0HbBjkVk+q8pCI3tEK wNAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704493011; x=1705097811; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4r9F1ve4tri+fejC8d02n5r3ZdvwikIuY6dGBcXdBSI=; b=kgPXV66m6a5ANnaGapANF9WegKomMtyTG5BQXUUS0YSWjNrf0HHZAoA8GGa8omuRT0 F6Td+7f7uAYin4dFUKzhBuG8rUUxpxdDPJnWzCrg1cfLuegpuoW40Og6FppB0FagsECK gJ3Qt8clXPV6D3ClAHVN+Qs3MKhlQdWpHNLHeXYIKOpOKZrvcNzRPHJYHwdGw61ZdPkO iscKR6TmVoYsFVc2yKuJk2TOREpv0QYRdgJ9eQD7fbdhY02bjl8bDqqBoAXJhSq2lpZQ 4bwg2hevZ44suLvLHwTGpzgUSt7yWmoZk3Q0K2bZUq84y9KIBH0E7EjVhh/VmrhOTAzs qgFA== X-Gm-Message-State: AOJu0Yx9v0HynlojTfL9p1zSOoFl7tnVhbYXGm5YnIrzov99+3xyIiIb 4EaFSCfBJUGZ3m+iqimHsfVc3iKUBq+hhw== X-Google-Smtp-Source: AGHT+IHqHvcXH6bkbwMMaWFecofubygJvsOiEtgFPI9vfu71h6yXu4g4xgjGMcx+EHBamxPXLGJisQ== X-Received: by 2002:a05:600c:84cf:b0:40d:9377:d988 with SMTP id er15-20020a05600c84cf00b0040d9377d988mr103684wmb.60.1704493011345; Fri, 05 Jan 2024 14:16:51 -0800 (PST) Received: from [192.168.69.100] (juv34-h02-176-184-26-1.dsl.sta.abo.bbox.fr. [176.184.26.1]) by smtp.gmail.com with ESMTPSA id e13-20020a05600c4e4d00b0040d79907acasm2768995wmq.26.2024.01.05.14.16.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 14:16:50 -0800 (PST) Message-ID: <4eb7a7f5-8cb5-41a3-ac26-9b9a77a34b09@linaro.org> Date: Fri, 5 Jan 2024 23:16:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase Content-Language: en-US To: =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , inesvarhol Cc: =?UTF-8?Q?In=C3=A8s_Varhol?= , qemu-devel@nongnu.org, Markus Armbruster , Alistair Francis , Arnaud Minier , Peter Maydell , Paolo Bonzini , Laurent Vivier , Thomas Huth , qemu-arm@nongnu.org References: <20231228161944.303768-1-ines.varhol@telecom-paris.fr> <20231228161944.303768-3-ines.varhol@telecom-paris.fr> <61fd13b3-7cc9-4e27-bf91-bd2b4aedf97b@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 5/1/24 11:24, Daniel P. Berrangé wrote: > On Thu, Jan 04, 2024 at 01:37:22PM +0000, inesvarhol wrote: >> >> Le jeudi 4 janvier 2024 à 14:05, Philippe Mathieu-Daudé a écrit : >> >> Hello, >> >>>> +static void test_edge_selector(void) >>>> +{ >>>> + enable_nvic_irq(EXTI0_IRQ); >>>> + >>>> + / Configure EXTI line 0 irq on rising edge */ >>>> + qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti", >>> >>> >>> Markus, this qtest use seems to expect some stability in QOM path... >>> >>> Inès, Arnaud, having the SoC unattached is dubious, it belongs to >>> the machine. >> >> Noted, we will fix that. >> Should we be concerned about the "stability in QOM path" ? > > QTest is a functional test harness that intentionally has knowledge > about QEMU internals. > > IOW, usage of particular QOM path in qtest does *not* imply that > QOM path needs to be stable. If QEMU internals change for whatever > reason, it is expected that QTests may need some updates to match. Good point. > QOM path stability only matters if there's a mgmt app facing use > case, which requires the app to have hardcoded knowledge of the > path. > > Even a mgmt app can use unstable QOM paths, provided it has a way > to dynamically detect the path to be used, instead of hardcoding > it. I can understand this use to lookup "on which CDROM tray is inserted the blkdrv named FOO", but to find a component on a well specified system on chip, this is overkill. > None the less, you may still choose to move it out of /unattached > at your discretion. Yeah we should clean those... Thanks for clarifying, Phil.