qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Bruce Rogers <brogers@suse.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com
Subject: Re: [PATCH] meson: install ivshmem-client and ivshmem-server
Date: Thu, 3 Sep 2020 17:44:25 +0200	[thread overview]
Message-ID: <4eba2feb-a9b3-8bb7-6ed7-6b02c79519b1@redhat.com> (raw)
In-Reply-To: <20200903153524.98168-1-brogers@suse.com>

On 03/09/20 17:35, Bruce Rogers wrote:
> Turn on the meson install flag for these executables
> 
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
>  contrib/ivshmem-client/meson.build | 2 +-
>  contrib/ivshmem-server/meson.build | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/contrib/ivshmem-client/meson.build b/contrib/ivshmem-client/meson.build
> index 1b171efb4f..83a559117f 100644
> --- a/contrib/ivshmem-client/meson.build
> +++ b/contrib/ivshmem-client/meson.build
> @@ -1,4 +1,4 @@
>  executable('ivshmem-client', files('ivshmem-client.c', 'main.c'),
>             dependencies: glib,
>             build_by_default: targetos == 'linux',
> -           install: false)
> +           install: true)
> diff --git a/contrib/ivshmem-server/meson.build b/contrib/ivshmem-server/meson.build
> index 3a53942201..a1c39aa3b3 100644
> --- a/contrib/ivshmem-server/meson.build
> +++ b/contrib/ivshmem-server/meson.build
> @@ -1,4 +1,4 @@
>  executable('ivshmem-server', files('ivshmem-server.c', 'main.c'),
>             dependencies: [qemuutil, rt],
>             build_by_default: targetos == 'linux',
> -           install: false)
> +           install: true)
> 

They weren't installed before the conversion, were they?

Paolo



  parent reply	other threads:[~2020-09-03 15:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 15:35 [PATCH] meson: install ivshmem-client and ivshmem-server Bruce Rogers
2020-09-03 15:42 ` Marc-André Lureau
2020-09-03 15:44 ` Paolo Bonzini [this message]
2020-09-03 15:49   ` Daniel P. Berrangé
2020-09-03 16:10     ` Bruce Rogers
2020-09-03 17:55     ` Paolo Bonzini
2020-09-04  7:24       ` Markus Armbruster
2020-09-04  7:57         ` Paolo Bonzini
2020-09-04  9:20           ` Markus Armbruster
2020-09-04 11:49             ` Bruce Rogers
2020-09-04 13:39               ` Markus Armbruster
2020-09-04  9:37         ` Philippe Mathieu-Daudé
2020-09-04 10:27           ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4eba2feb-a9b3-8bb7-6ed7-6b02c79519b1@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=brogers@suse.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).