From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
Pierrick Bouvier <pierrick.bouvier@linaro.org>
Cc: qemu-devel@nongnu.org, sw@weilnetz.de, kkostiuk@redhat.com,
clg@kaod.org, alex.bennee@linaro.org
Subject: Re: [PATCH 1/4] util/cacheflush: fix illegal instruction on windows-arm64
Date: Tue, 14 Feb 2023 07:02:12 -1000 [thread overview]
Message-ID: <4ed07e71-17df-fca1-7e80-0b3aed7ca910@linaro.org> (raw)
In-Reply-To: <CAFEAcA--p8kRsbTy4vg83fEap_MO--HEMcOGGnnXzcxJYZW6Mw@mail.gmail.com>
On 2/14/23 06:44, Peter Maydell wrote:
> This will cause us to not use the generic aarch64 flush_idcache_range(),
> which uses DC CVAU and IC IVAU. Does that not work on Windows?
>
> If it doesn't then I think the ifdeffery would be more clearly
> structured as
>
> #elif defined(__aarch64__)
>
> ifdef CONFIG_DARWIN
> [macos implementation of flush_idcache_range]
> #elif defined(CONFIG_WIN32)
> /* Explanation here of why the generic version doesn't work */
> #else
> /* generic version */
> #endif
>
> #elif defined(__mips__)
More specifically, there *must* be a replacement, or TCG will not work.
It appears as if FlushInstructionCache is the right syscall on windows.
I cannot find documentation for a data cache flush. But until there is also a way to
allocate split w^x memory regions (tcg/region.c, alloc_code_gen_buffer_splitwx), you need
not worry about that. You could reasonably assert(rx == rw) there.
r~
next prev parent reply other threads:[~2023-02-14 17:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 16:13 [PATCH 0/4] Adds support for running QEMU natively on windows-arm64 Pierrick Bouvier
2023-02-13 16:13 ` [PATCH 1/4] util/cacheflush: fix illegal instruction " Pierrick Bouvier
2023-02-14 16:44 ` Peter Maydell
2023-02-14 17:02 ` Richard Henderson [this message]
2023-02-15 12:49 ` Pierrick Bouvier
2023-02-15 18:22 ` Richard Henderson
2023-02-16 12:53 ` Pierrick Bouvier
2023-02-13 16:13 ` [PATCH 2/4] sysemu/os-win32: fix setjmp/longjmp " Pierrick Bouvier
2023-02-14 7:11 ` Philippe Mathieu-Daudé
2023-02-14 8:16 ` Pierrick Bouvier
2023-02-13 16:13 ` [PATCH 3/4] qga/vss-win32: fix warning for clang++-15 Pierrick Bouvier
2023-02-13 16:20 ` Konstantin Kostiuk
2023-02-13 18:08 ` Cédric Le Goater
2023-02-13 16:13 ` [PATCH 4/4] target/ppc: fix warning with clang-15 Pierrick Bouvier
2023-02-13 18:08 ` Cédric Le Goater
2023-02-14 7:14 ` Philippe Mathieu-Daudé
2023-02-14 7:57 ` Pierrick Bouvier
2023-02-14 18:10 ` Richard Henderson
2023-02-15 10:58 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ed07e71-17df-fca1-7e80-0b3aed7ca910@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=clg@kaod.org \
--cc=kkostiuk@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).