From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Antonio Caggiano <quic_acaggian@quicinc.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 2/3] system/vl.c: Expand OpenGL related errors
Date: Tue, 6 Aug 2024 21:27:14 +0200 [thread overview]
Message-ID: <4ed90c17-03ab-4e3d-889a-42a986b625bd@linaro.org> (raw)
In-Reply-To: <137030be-f5b0-45e4-97d5-0d17aa8d6347@quicinc.com>
On 6/8/24 17:20, Antonio Caggiano wrote:
> Hi
>
> On 06/08/2024 15:41, Alex Bennée wrote:
>> Peter Maydell <peter.maydell@linaro.org> writes:
>>
>>> Expand the OpenGL related error messages we produce for various
>>> "OpenGL not present/not supported" cases, to hopefully guide the
>>> user towards how to fix things.
>>>
>>> Now if the user tries to enable GL on a backend that doesn't
>>> support it the error message is a bit more precise:
>>>
>>> $ qemu-system-aarch64 -M virt -device virtio-gpu-gl -display
>>> curses,gl=on
>>> qemu-system-aarch64: OpenGL is not supported by display backend 'curses'
>>>
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>> ---
>>> system/vl.c | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/system/vl.c b/system/vl.c
>>> index 9e8f16f1551..213ee6a6a92 100644
>>> --- a/system/vl.c
>>> +++ b/system/vl.c
>>> @@ -1973,9 +1973,10 @@ static void qemu_create_early_backends(void)
>>> if (dpy.has_gl && dpy.gl != DISPLAYGL_MODE_OFF &&
>>> display_opengl == 0) {
>>> #if defined(CONFIG_OPENGL)
>>> - error_report("OpenGL is not supported by the display");
>>> + error_report("OpenGL is not supported by display backend '%s'",
>>> + DisplayType_str(dpy.type));
>>> #else
>>> - error_report("OpenGL support is disabled");
>>> + error_report("OpenGL support was disabled when QEMU was
>>> compiled");
>>
>> Maybe "OpenGL support was not enabled in this build of QEMU"?
>
> To stay aligned with the other changes, this can provide even more
> details with another hint.
>
> "OpenGL support was disabled at QEMU configuration time."
> "It can be enabled by running `./configure --enable-opengl` before
> compilation"
>
>
> BTW, whole series:
> Reviewed-by: Antonio Caggiano <quic_acaggian@quicinc.com>
Thanks Antonio. I already posted the pull request and it is
being tested. I'll include your R-b tag if there is an issue
and I need to repost it.
>
> Cheers,
> Antonio
>
>>
>> Anyway:
>>
>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>>
>>
>>
>>> #endif
>>> exit(1);
>>> }
>>
>
next prev parent reply other threads:[~2024-08-06 19:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 15:41 [PATCH 0/3] virtio-gpu-gl: Improve OpenGL and related display error messages Peter Maydell
2024-07-31 15:41 ` [PATCH 1/3] hw/display/virtio-gpu: Improve "opengl is not available" error message Peter Maydell
2024-08-06 7:33 ` Philippe Mathieu-Daudé
2024-08-06 13:37 ` Alex Bennée
2024-07-31 15:41 ` [PATCH 2/3] system/vl.c: Expand OpenGL related errors Peter Maydell
2024-08-06 7:31 ` Philippe Mathieu-Daudé
2024-08-06 13:41 ` Alex Bennée
2024-08-06 15:20 ` Antonio Caggiano
2024-08-06 19:27 ` Philippe Mathieu-Daudé [this message]
2024-07-31 15:41 ` [PATCH 3/3] ui/console: Note in '-display help' that some backends support suboptions Peter Maydell
2024-08-06 7:47 ` Philippe Mathieu-Daudé
2024-07-31 15:59 ` [PATCH 0/3] virtio-gpu-gl: Improve OpenGL and related display error messages Marc-André Lureau
2024-08-06 12:46 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ed90c17-03ab-4e3d-889a-42a986b625bd@linaro.org \
--to=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_acaggian@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).