qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Flavio Leitner <fbl@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] vhost-user breaks after 96a3d98.
Date: Tue, 3 Jan 2017 11:09:40 +0800	[thread overview]
Message-ID: <4eda1813-d732-5dfc-e6ff-29ac95fe22d8@redhat.com> (raw)
In-Reply-To: <20161230104130.29ff671b@x240.lan>



On 2016年12月30日 20:41, Flavio Leitner wrote:
> Hi,
>
> While I was testing vhost-user using OVS 2.5 and DPDK 2.2.0 in the
> host and testpmd dpdk 2.2.0 in the guest, I found that the commit
> below breaks the environment and no packets gets into the guest.
>
> dpdk port --> OVS --> vhost-user --> guest --> testpmd
>                           ^--- drops here         ^--- no packets here.
>
> commit 96a3d98d2cdbd897ff5ab33427aa4cfb94077665
> Author: Jason Wang <jasowang@redhat.com>
> Date:   Mon Aug 1 16:07:58 2016 +0800
>
>      vhost: don't set vring call if no vector
>      
>      We used to set vring call fd unconditionally even if guest driver does
>      not use MSIX for this vritqueue at all. This will cause lots of
>      unnecessary userspace access and other checks for drivers does not use
>      interrupt at all (e.g virtio-net pmd). So check and clean vring call
>      fd if guest does not use any vector for this virtqueue at
>      all.
> [...]
>
> Thanks,

Hi Flavio:

Thanks for reporting this issue, could this be a bug of vhost-user? (I 
believe virito-net pmd does not use interrupt for rx/tx at all)

Anyway, will try to reproduce it.

  reply	other threads:[~2017-01-03  3:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30 12:41 [Qemu-devel] vhost-user breaks after 96a3d98 Flavio Leitner
2017-01-03  3:09 ` Jason Wang [this message]
2017-01-03 10:28   ` Jason Wang
2017-01-03 16:27     ` Michael S. Tsirkin
2017-01-04  3:26       ` Jason Wang
2017-01-04  7:52         ` Jason Wang
2017-01-04 13:00           ` Flavio Leitner
2017-01-04 13:10             ` Michael S. Tsirkin
2017-01-03 17:33     ` Flavio Leitner
2017-01-03 22:13       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4eda1813-d732-5dfc-e6ff-29ac95fe22d8@redhat.com \
    --to=jasowang@redhat.com \
    --cc=fbl@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).