From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:50544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxeuT-0000GZ-HH for qemu-devel@nongnu.org; Sat, 23 Feb 2019 16:32:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxeuS-0007li-Bs for qemu-devel@nongnu.org; Sat, 23 Feb 2019 16:32:37 -0500 References: <20190223000614.13894-1-jsnow@redhat.com> <20190223000614.13894-8-jsnow@redhat.com> From: Eric Blake Message-ID: <4ede85a6-a7e1-a231-db9d-44294ebc36a7@redhat.com> Date: Sat, 23 Feb 2019 15:32:23 -0600 MIME-Version: 1.0 In-Reply-To: <20190223000614.13894-8-jsnow@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 07/10] block/dirty-bitmaps: unify qmp_locked and user_locked calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: Markus Armbruster , Kevin Wolf , vsementsov@virtuozzo.com, Juan Quintela , Max Reitz , libvir-list@redhat.com, "Dr. David Alan Gilbert" , Stefan Hajnoczi , Fam Zheng On 2/22/19 6:06 PM, John Snow wrote: > These mean the same thing now. Unify them and rename the merged call > bdrv_dirty_bitmap_busy to indicate semantically what we are describing, > as well as help disambiguate from the various _locked and _unlocked > versions of bitmap helpers that refer to mutex locks. > > Signed-off-by: John Snow > --- Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org