From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0D83C43334 for ; Thu, 21 Jul 2022 13:03:29 +0000 (UTC) Received: from localhost ([::1]:57040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oEVpw-0007Lk-QN for qemu-devel@archiver.kernel.org; Thu, 21 Jul 2022 09:03:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oEVnS-0005fp-JD for qemu-devel@nongnu.org; Thu, 21 Jul 2022 09:00:58 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]:44554) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oEVnK-0002oB-4P for qemu-devel@nongnu.org; Thu, 21 Jul 2022 09:00:51 -0400 Received: by mail-ed1-x52f.google.com with SMTP id m16so2026462edb.11 for ; Thu, 21 Jul 2022 06:00:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GktTuaL+5l+pkhSlt+t6BusBHwUozEKjvQjMZt+El74=; b=Hm8lU1NHvlEc/Xm4T1uGybCj0EA0/65U1ES822dyDSE83NgCKvBzICh7tOvGf2jWDu Ukb/4b8/eMrl0O6Bk18uRsfm78gxqL4e9NWmIJbe0nnw0FJ7iDAFr5/6K9FcX6kKyYYs 7U4aFw1fKzjVH0jHEjd9Y2Ajnrm820RKv0xshCEu3Oc+pVxxQggWXjPRNZiP2FC12aXD UhEnbW1F14dvYc5IpMtp30So+Et7XejHK+Cc83lTlaG/rram/glO5VjZs0pnBj5j1lwG tyGC+EKpB6COMM7itPOj3Xgt3W4qDcOO+UhuA0dgZZSq8zvLyBuxqcdKGsNbZptJw7F7 evvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GktTuaL+5l+pkhSlt+t6BusBHwUozEKjvQjMZt+El74=; b=umL6ccbf7IENLaAixVWRIZOP4jXlRj23vHFLFEGb1gC1iA0mlSWUglsl1g8nbaPgqH IHr1aPxUihYg9dmoLTZewAeDv0xsAn1b/n/NuONZSuJVa6FlQIThNftTNm9keX3RC65q k1Uwyt0Nbi51Rv04lP7PUqpb5iP3mMXNIH2OJtVsy+6nkNpdWt+QALw1zscJcrq3Drd1 JV0dYYX8fWPF+pKuHNYvcG3LgAhzVLnTj1n1M28bxxJg9P/ibBJNIaorDSqXyDZji66y xfk3Sgj3Pp8GTFeGzGPWfNqlvAoEwEsDME/cVfYxYz1V5pLD4r5iWj3XNLN1RsQ4HAql Sh8w== X-Gm-Message-State: AJIora9gIuIhGUVo37ux4wMPpoCP+p9Vcq3DjomuuWlEHEw5mKuf3aGO Q8NjehMwI5Eg0Qzm+oqzNgs= X-Google-Smtp-Source: AGRyM1ue9fx3RqmR7FOIrfh9eNaEispudoRCnOnccw3TxWzS1OLKOL12mZY8hjWxdZDto0Ar0DOzqA== X-Received: by 2002:aa7:d9d3:0:b0:43b:c457:fb06 with SMTP id v19-20020aa7d9d3000000b0043bc457fb06mr4245654eds.5.1658408444527; Thu, 21 Jul 2022 06:00:44 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id c14-20020aa7d60e000000b0043b240ce57bsm964014edr.82.2022.07.21.06.00.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jul 2022 06:00:43 -0700 (PDT) Message-ID: <4ef7500c-cce7-e7eb-9c4f-aedf2ee000bd@redhat.com> Date: Thu, 21 Jul 2022 15:00:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v7] hw/i386: pass RNG seed via setup_data entry Content-Language: en-US To: "Jason A. Donenfeld" , "Michael S. Tsirkin" , QEMU Developers Cc: Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , Peter Maydell , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Laurent Vivier References: <20220721125636.446842-1-Jason@zx2c4.com> From: Paolo Bonzini In-Reply-To: <20220721125636.446842-1-Jason@zx2c4.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=paolo.bonzini@gmail.com; helo=mail-ed1-x52f.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 7/21/22 14:56, Jason A. Donenfeld wrote: > Tiny machines optimized for fast boot time generally don't use EFI, > which means a random seed has to be supplied some other way. For this > purpose, Linux (≥5.20) supports passing a seed in the setup_data table > with SETUP_RNG_SEED, specially intended for hypervisors, kexec, and > specialized bootloaders. The linked commit shows the upstream kernel > implementation. > > At Paolo's request, we don't pass these to versioned machine types ≤7.0. > > Link: https://git.kernel.org/tip/tip/c/68b8e9713c8 > Cc: Marcel Apfelbaum > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc: Peter Maydell > Cc: Philippe Mathieu-Daudé > Cc: Laurent Vivier > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Jason A. Donenfeld LGTM. Paolo