From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] build: remove CONFIG_LIBDECNUMBER
Date: Tue, 10 Oct 2017 19:14:21 +0200 [thread overview]
Message-ID: <4ef9d11c-e63a-4ffb-d6a4-49e8a7cee233@redhat.com> (raw)
In-Reply-To: <025cc2d9-df73-71a2-6b08-6c6a64cf17dd@linaro.org>
On 10/10/2017 18:39, Richard Henderson wrote:
> On 10/10/2017 07:57 AM, Paolo Bonzini wrote:
>> On 10/10/2017 16:47, Richard Henderson wrote:
>>> On 10/10/2017 03:26 AM, Paolo Bonzini wrote:
>>>> It is used only by PPC TCG, so just move it in target/ppc/Makefile.objs
>>>>
>>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>>
>>> FWIW, it *should* be used by target/s390x as well.
>>>
>>>> diff --git a/target/ppc/Makefile.objs b/target/ppc/Makefile.objs
>>>> index f92ba67ebd..ba61012bef 100644
>>>> --- a/target/ppc/Makefile.objs
>>>> +++ b/target/ppc/Makefile.objs
>>>> @@ -15,5 +15,10 @@ obj-y += int_helper.o
>>>> obj-y += timebase_helper.o
>>>> obj-y += misc_helper.o
>>>> obj-y += mem_helper.o
>>>> +obj-y += ../../libdecnumber/decContext.o
>>>> +obj-y += ../../libdecnumber/decNumber.o
>>>> +obj-y += ../../libdecnumber/dpd/decimal32.o
>>>> +obj-y += ../../libdecnumber/dpd/decimal64.o
>>>> +obj-y += ../../libdecnumber/dpd/decimal128.o
>>>> obj-$(CONFIG_USER_ONLY) += user_only_helper.o
>>>> obj-y += gdbstub.o
>>>
>>> I suppose this isn't horrible, if it needed to be replicated.
>>
>> If it has to be replicated, it should be
>>
>> obj-y += ../../libdecnumber/
>>
>> I'll post v2.
>
> I think I wasn't clear -- s390x does not yet use libdecnumber because we
> haven't written the emulation instructions. But we should do. It shouldn't
> even be particularly hard, since all of the heavy lifting is in the library itself.
>
> So no need to add anything at the moment; you've simply answered my question
> about what *should* happen.
Well, if it should happen later, it might as well happen now even if
it's not replicated...
Paolo
prev parent reply other threads:[~2017-10-10 17:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 10:26 [Qemu-devel] [PATCH] build: remove CONFIG_LIBDECNUMBER Paolo Bonzini
2017-10-10 14:47 ` Richard Henderson
2017-10-10 14:57 ` Paolo Bonzini
2017-10-10 16:39 ` Richard Henderson
2017-10-10 17:14 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ef9d11c-e63a-4ffb-d6a4-49e8a7cee233@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).