qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "lvivier@redhat.com" <lvivier@redhat.com>,
	"thuth@redhat.com" <thuth@redhat.com>,
	"ehabkost@redhat.com" <ehabkost@redhat.com>,
	"mst@redhat.com" <mst@redhat.com>,
	"Liu, Jingqi" <jingqi.liu@intel.com>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"imammedo@redhat.com" <imammedo@redhat.com>,
	"Williams,  Dan J" <dan.j.williams@intel.com>,
	"rth@twiddle.net" <rth@twiddle.net>
Subject: Re: [PATCH 0/3] account for NVDIMM nodes during SRAT generation
Date: Tue, 12 May 2020 18:45:44 +0000	[thread overview]
Message-ID: <4f0a068c6a3d388d4ee358d9d50d550eb95d8bf4.camel@intel.com> (raw)
In-Reply-To: <20200428012810.10877-1-vishal.l.verma@intel.com>

On Mon, 2020-04-27 at 19:28 -0600, Vishal Verma wrote:
> On the command line, one can specify a NUMA node for NVDIMM devices. If
> we set up the topology to give NVDIMMs their own nodes, i.e. not
> containing any CPUs or regular memory, qemu doesn't populate SRAT memory
> affinity structures for these nodes. However the NFIT does reference
> those proximity domains.
> 
> As a result, Linux, while parsing the SRAT, fails to initialize node
> related structures for these nodes, and they never end up in the
> nodes_possible map. When these are onlined at a later point (via
> hotplug), this causes problems.
> 
> I've followed the instructions in bios-tables-test.c to update the
> expected SRAT binary, and the tests (make check) pass. Patches 1 and 3
> are the relevant ones for the binary update.
> 
> Patch 2 is the main patch which changes SRAT generation.
> 
> Vishal Verma (3):
>   diffs-allowed: add the SRAT AML to diffs-allowed
>   hw/acpi-build: account for NVDIMM numa nodes in SRAT
>   tests/acpi: update expected SRAT files
> 
>  hw/i386/acpi-build.c             |  20 ++++++++++++++++++++
>  tests/data/acpi/pc/SRAT.dimmpxm  | Bin 392 -> 392 bytes
>  tests/data/acpi/q35/SRAT.dimmpxm | Bin 392 -> 392 bytes
>  3 files changed, 20 insertions(+)
> 
Hi All - Just pinging this patchset again. I neglected to CC maintainers
in the original posting, doing so now. The full series can be seen here:

https://lore.kernel.org/qemu-devel/20200428012810.10877-1-vishal.l.verma@intel.com/

If I should resend the patches, please let me know and I'll be happy to
do so.

      parent reply	other threads:[~2020-05-12 18:47 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-28  1:28 [PATCH 0/3] account for NVDIMM nodes during SRAT generation Vishal Verma
2020-04-28  1:28 ` [PATCH 1/3] diffs-allowed: add the SRAT AML to diffs-allowed Vishal Verma
2020-04-28  1:28 ` [PATCH 2/3] hw/acpi-build: account for NVDIMM numa nodes in SRAT Vishal Verma
2020-04-30  3:42   ` Liu, Jingqi
2020-05-21 15:16   ` Igor Mammedov
2020-05-28  1:24     ` Verma, Vishal L
2020-05-28 10:41       ` Igor Mammedov
2020-05-28 16:27         ` Verma, Vishal L
2020-04-28  1:28 ` [PATCH 3/3] tests/acpi: update expected SRAT files Vishal Verma
2020-04-28  2:44 ` [PATCH 0/3] account for NVDIMM nodes during SRAT generation no-reply
2020-04-28 16:02   ` Verma, Vishal L
2020-05-12 18:45 ` Verma, Vishal L [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f0a068c6a3d388d4ee358d9d50d550eb95d8bf4.camel@intel.com \
    --to=vishal.l.verma@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jingqi.liu@intel.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).