qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Dongjiu Geng <gengdongjiu@huawei.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	Xiang Zheng <zhengxiang9@huawei.com>,
	qemu-arm@nongnu.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH] hw/arm: Restrict APEI tables generation to the 'virt' machine
Date: Wed, 30 Sep 2020 13:34:01 +0200	[thread overview]
Message-ID: <4f2f3b35-a0a9-1a2e-4d14-b6aad728d6a6@redhat.com> (raw)
In-Reply-To: <5b5e1b32-0e9b-8154-e645-9b922119db33@huawei.com>

On 9/30/20 1:05 PM, Dongjiu Geng wrote:
> 
> On 2020/9/30 18:35, Philippe Mathieu-Daudé wrote:
>> On 9/30/20 7:08 AM, Dongjiu Geng wrote:
>>> On 2020/9/29 20:56, Philippe Mathieu-Daudé wrote:
>>>> As only the Virt machine uses the RAS Virtualization feature (see
>>>> commit 2afa8c8519: "hw/arm/virt: Introduce a RAS machine option"),
>>>> restrict the APEI tables generation code to the virt machine.
>>>
>>> APEI is a generic feature for X86 and arm64.  X86 platform also can use it, although currently it was mainly
>>> used by ARM64. what is reason that we restrict APEI tables generation to the 'virt' machine?
>>
>> It is currently only selected on (all) the ARM machines, not the X86
>> ones. I am simply restricting it to the 'virt' machine which is the
>> single one enabling the RAS. Without RAS the table is not built, so
>> for the case of the SBSA-Ref machine this code is unreachable, no need
>> to select ACPI_APEI.
>>
>> When a X86 machine configure a RAS it will have to 'select ACPI_APEI'
>> to get it built (I'm not forbidding it, I'm restricting it to where
>> it is used).
> 
> Got it, thanks for the explanation.
> 
> Reviewed-by: Dongjiu Geng <gengdongjiu@huawei.com>

Thanks, I'll reword the description, ...

> 
> BTW:There is a build test error, but it is seems do not related with this patch.
> https://patchew.org/logs/20200929125609.1088330-1-philmd@redhat.com/testing.docker-quick@centos7/?type=message

... and look at that error before posting.

> 
>>
>>>
>>>>
>>>> Fixes: aa16508f1d ("ACPI: Build related register address fields via hardware error fw_cfg blob")
>>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>> ---
>>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>>> Cc: Xiang Zheng <zhengxiang9@huawei.com>
>>>> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>>> Cc: Igor Mammedov <imammedo@redhat.com>
>>>> Cc: Dongjiu Geng <gengdongjiu@huawei.com>
>>>> Cc: Michael S. Tsirkin <mst@redhat.com>
>>>> ---
>>>>  default-configs/arm-softmmu.mak | 1 -
>>>>  hw/arm/Kconfig                  | 1 +
>>>>  2 files changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
>>>> index 9a94ebd0be..08a32123b4 100644
>>>> --- a/default-configs/arm-softmmu.mak
>>>> +++ b/default-configs/arm-softmmu.mak
>>>> @@ -43,4 +43,3 @@ CONFIG_FSL_IMX7=y
>>>>  CONFIG_FSL_IMX6UL=y
>>>>  CONFIG_SEMIHOSTING=y
>>>>  CONFIG_ALLWINNER_H3=y
>>>> -CONFIG_ACPI_APEI=y
>>>> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
>>>> index f303c6bead..7d040827af 100644
>>>> --- a/hw/arm/Kconfig
>>>> +++ b/hw/arm/Kconfig
>>>> @@ -26,6 +26,7 @@ config ARM_VIRT
>>>>      select ACPI_MEMORY_HOTPLUG
>>>>      select ACPI_HW_REDUCED
>>>>      select ACPI_NVDIMM
>>>> +    select ACPI_APEI
>>>>  
>>>>  config CHEETAH
>>>>      bool
>>>>
>>>
>>
>> .
>>
> 



  reply	other threads:[~2020-09-30 11:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-29 12:56 [PATCH] hw/arm: Restrict APEI tables generation to the 'virt' machine Philippe Mathieu-Daudé
2020-09-29 19:37 ` no-reply
2020-09-30  5:08 ` Dongjiu Geng
2020-09-30 10:35   ` Philippe Mathieu-Daudé
2020-09-30 11:05     ` Dongjiu Geng
2020-09-30 11:34       ` Philippe Mathieu-Daudé [this message]
2020-09-30 10:47 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f2f3b35-a0a9-1a2e-4d14-b6aad728d6a6@redhat.com \
    --to=philmd@redhat.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=gengdongjiu@huawei.com \
    --cc=imammedo@redhat.com \
    --cc=lersek@redhat.com \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zhengxiang9@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).