qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>
Subject: Re: [PATCH] travis.yml: enable linux-gcc-debug-tcg cache
Date: Thu, 24 Oct 2019 18:21:55 +0200	[thread overview]
Message-ID: <4f36130d-f2cc-2432-7098-b73f82c1501e@redhat.com> (raw)
In-Reply-To: <20191024160619.14179-1-alex.bennee@linaro.org>

On 10/24/19 6:06 PM, Alex Bennée wrote:
> Create a new cache for the --enable-debug-tcg builds which is separate
> from the normal debug builds which generate different code. We also
> enable debug-tcg for the new plugins based builds as we want to ensure
> any breakage to TCG is picked up by the sanity checks.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   .travis.yml | 14 +++++++-------
>   1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index e3f10a93683..34bc8134f5b 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -135,7 +135,7 @@ matrix:
>       # TCG debug can be run just on its own and is mostly agnostic to user/softmmu distinctions
>       - env:	
>           - CONFIG="--enable-debug-tcg --disable-system"
> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug"
> +        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg"

This one runs default TEST_CMD="make check -j3 V=1"

>   
>   
>       - env:
> @@ -336,29 +336,29 @@ matrix:
>       - env:
>           - CONFIG="--disable-system --enable-debug-tcg"
>           - TEST_CMD="make -j3 check-tcg V=1"

And this one "check-tcg", OK.
(Maybe we can reorder the $CONFIG arguments so both jobs are more similar).

Too bad Travis 'stages' are an enterprise feature:

https://docs.travis-ci.com/user/conditional-builds-stages-jobs/#conditional-stages

Because here we are building 2x the same, and cache isn't used.

Not this patch problem.

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
> +        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg"
>   
>   
>       # Run check-tcg against linux-user (with plugins)
>       # we skip sparc64-linux-user until it has been fixed somewhat
>       - env:
> -        - CONFIG="--disable-system --enable-plugins --target-list-exclude=sparc64-linux-user"
> +        - CONFIG="--disable-system --enable-plugins --enable-debug-tcg --target-list-exclude=sparc64-linux-user"
>           - TEST_CMD="make -j3 check-tcg V=1"
> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
> +        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg"
>   
>   
>       # Run check-tcg against softmmu targets
>       - env:
>           - CONFIG="--enable-debug-tcg --target-list=xtensa-softmmu,arm-softmmu,aarch64-softmmu,alpha-softmmu"
>           - TEST_CMD="make -j3 check-tcg V=1"
> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
> +        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg"
>   
>   
>       # Run check-tcg against softmmu targets (with plugins)
>       - env:
> -        - CONFIG="--enable-plugins --target-list=xtensa-softmmu,arm-softmmu,aarch64-softmmu,alpha-softmmu"
> +        - CONFIG="--enable-plugins --enable-debug-tcg --target-list=xtensa-softmmu,arm-softmmu,aarch64-softmmu,alpha-softmmu"
>           - TEST_CMD="make -j3 check-tcg V=1"
> -        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default"
> +        - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-debug-tcg"
>   
>   
>       # Release builds
> 



  reply	other threads:[~2019-10-24 16:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 16:06 [PATCH] travis.yml: enable linux-gcc-debug-tcg cache Alex Bennée
2019-10-24 16:21 ` Philippe Mathieu-Daudé [this message]
2019-10-24 17:06   ` Alex Bennée
2019-10-24 17:59     ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f36130d-f2cc-2432-7098-b73f82c1501e@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=fam@euphon.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).