qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, hreitz@redhat.com, qemu-block@nongnu.org
Subject: Re: [PATCH] qemu-iotests: flush after every test
Date: Wed, 6 Oct 2021 17:42:34 +0200	[thread overview]
Message-ID: <4f3fa32a-54da-1b5e-e35a-4eece062a7bf@redhat.com> (raw)
In-Reply-To: <20211006092726.383737-1-pbonzini@redhat.com>

On 10/6/21 11:27, Paolo Bonzini wrote:
> This makes it possible to see what is happening, even if the output of
> "make check-block" is not sent to a tty (for example if it is sent to
> grep or tee).
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/qemu-iotests/testrunner.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py
> index 4a6ec421ed..b76db57e4c 100644
> --- a/tests/qemu-iotests/testrunner.py
> +++ b/tests/qemu-iotests/testrunner.py
> @@ -340,6 +340,7 @@ def run_tests(self, tests: List[str]) -> bool:
>              elif res.status == 'not run':
>                  notrun.append(name)
>  
> +            sys.stdout.flush()

Shouldn't we flush stderr too?

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>



  parent reply	other threads:[~2021-10-06 16:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06  9:27 [PATCH] qemu-iotests: flush after every test Paolo Bonzini
2021-10-06 14:08 ` Richard Henderson
2021-10-06 15:42 ` Philippe Mathieu-Daudé [this message]
2021-10-07 11:47   ` Paolo Bonzini
2021-10-11 13:25 ` Hanna Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f3fa32a-54da-1b5e-e35a-4eece062a7bf@redhat.com \
    --to=philmd@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).