* [PATCH] qemu-iotests: flush after every test
@ 2021-10-06 9:27 Paolo Bonzini
2021-10-06 14:08 ` Richard Henderson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Paolo Bonzini @ 2021-10-06 9:27 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, hreitz, qemu-block
This makes it possible to see what is happening, even if the output of
"make check-block" is not sent to a tty (for example if it is sent to
grep or tee).
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/qemu-iotests/testrunner.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py
index 4a6ec421ed..b76db57e4c 100644
--- a/tests/qemu-iotests/testrunner.py
+++ b/tests/qemu-iotests/testrunner.py
@@ -340,6 +340,7 @@ def run_tests(self, tests: List[str]) -> bool:
elif res.status == 'not run':
notrun.append(name)
+ sys.stdout.flush()
if res.interrupted:
break
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] qemu-iotests: flush after every test
2021-10-06 9:27 [PATCH] qemu-iotests: flush after every test Paolo Bonzini
@ 2021-10-06 14:08 ` Richard Henderson
2021-10-06 15:42 ` Philippe Mathieu-Daudé
2021-10-11 13:25 ` Hanna Reitz
2 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2021-10-06 14:08 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: kwolf, hreitz, qemu-block
On 10/6/21 2:27 AM, Paolo Bonzini wrote:
> This makes it possible to see what is happening, even if the output of
> "make check-block" is not sent to a tty (for example if it is sent to
> grep or tee).
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> tests/qemu-iotests/testrunner.py | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qemu-iotests: flush after every test
2021-10-06 9:27 [PATCH] qemu-iotests: flush after every test Paolo Bonzini
2021-10-06 14:08 ` Richard Henderson
@ 2021-10-06 15:42 ` Philippe Mathieu-Daudé
2021-10-07 11:47 ` Paolo Bonzini
2021-10-11 13:25 ` Hanna Reitz
2 siblings, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-10-06 15:42 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: kwolf, hreitz, qemu-block
On 10/6/21 11:27, Paolo Bonzini wrote:
> This makes it possible to see what is happening, even if the output of
> "make check-block" is not sent to a tty (for example if it is sent to
> grep or tee).
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/qemu-iotests/testrunner.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py
> index 4a6ec421ed..b76db57e4c 100644
> --- a/tests/qemu-iotests/testrunner.py
> +++ b/tests/qemu-iotests/testrunner.py
> @@ -340,6 +340,7 @@ def run_tests(self, tests: List[str]) -> bool:
> elif res.status == 'not run':
> notrun.append(name)
>
> + sys.stdout.flush()
Shouldn't we flush stderr too?
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qemu-iotests: flush after every test
2021-10-06 15:42 ` Philippe Mathieu-Daudé
@ 2021-10-07 11:47 ` Paolo Bonzini
0 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2021-10-07 11:47 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: kwolf, hreitz, qemu-block
On 06/10/21 17:42, Philippe Mathieu-Daudé wrote:
> On 10/6/21 11:27, Paolo Bonzini wrote:
>> This makes it possible to see what is happening, even if the output of
>> "make check-block" is not sent to a tty (for example if it is sent to
>> grep or tee).
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>> tests/qemu-iotests/testrunner.py | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py
>> index 4a6ec421ed..b76db57e4c 100644
>> --- a/tests/qemu-iotests/testrunner.py
>> +++ b/tests/qemu-iotests/testrunner.py
>> @@ -340,6 +340,7 @@ def run_tests(self, tests: List[str]) -> bool:
>> elif res.status == 'not run':
>> notrun.append(name)
>>
>> + sys.stdout.flush()
>
> Shouldn't we flush stderr too?
It's never used by the program.
Paolo
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qemu-iotests: flush after every test
2021-10-06 9:27 [PATCH] qemu-iotests: flush after every test Paolo Bonzini
2021-10-06 14:08 ` Richard Henderson
2021-10-06 15:42 ` Philippe Mathieu-Daudé
@ 2021-10-11 13:25 ` Hanna Reitz
2 siblings, 0 replies; 5+ messages in thread
From: Hanna Reitz @ 2021-10-11 13:25 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: kwolf, qemu-block
On 06.10.21 11:27, Paolo Bonzini wrote:
> This makes it possible to see what is happening, even if the output of
> "make check-block" is not sent to a tty (for example if it is sent to
> grep or tee).
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> tests/qemu-iotests/testrunner.py | 1 +
> 1 file changed, 1 insertion(+)
Thanks, applied to my block branch:
https://gitlab.com/hreitz/qemu/-/commits/block/
Hanna
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-11 13:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-06 9:27 [PATCH] qemu-iotests: flush after every test Paolo Bonzini
2021-10-06 14:08 ` Richard Henderson
2021-10-06 15:42 ` Philippe Mathieu-Daudé
2021-10-07 11:47 ` Paolo Bonzini
2021-10-11 13:25 ` Hanna Reitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).