From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, jsnow@redhat.com, den@openvz.org
Subject: Re: [Qemu-devel] [PATCH v6 5/5] block/backup: refactor: split out backup_calculate_cluster_size
Date: Fri, 26 Apr 2019 20:30:08 +0200 [thread overview]
Message-ID: <4f5ed0c3-83d0-bcbe-5866-e0aab67f188f@redhat.com> (raw)
In-Reply-To: <20190415144948.78568-6-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
On 15.04.19 16:49, Vladimir Sementsov-Ogievskiy wrote:
> Split out cluster_size calculation. Move copy-bitmap creation above
> block-job creation, as we are going to share it with upcoming
> backup-top filter, which also should be created before actual block job
> creation.
>
> Also, while being here, drop unnecessary "goto error" from
> bdrv_getlength error path.
It isn’t unnecessary, though. Before this, we invoke
bdrv_dirty_bitmap_create_successor(), so the error path has to clean
that up with bdrv_reclaim_dirty_bitmap().
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Max Reitz <mreitz@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: kwolf@redhat.com, den@openvz.org, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6 5/5] block/backup: refactor: split out backup_calculate_cluster_size
Date: Fri, 26 Apr 2019 20:30:08 +0200 [thread overview]
Message-ID: <4f5ed0c3-83d0-bcbe-5866-e0aab67f188f@redhat.com> (raw)
Message-ID: <20190426183008.FGwWML0whHXFbjKbTQLsjW83qLqoEKUmgIZumjedTno@z> (raw)
In-Reply-To: <20190415144948.78568-6-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 557 bytes --]
On 15.04.19 16:49, Vladimir Sementsov-Ogievskiy wrote:
> Split out cluster_size calculation. Move copy-bitmap creation above
> block-job creation, as we are going to share it with upcoming
> backup-top filter, which also should be created before actual block job
> creation.
>
> Also, while being here, drop unnecessary "goto error" from
> bdrv_getlength error path.
It isn’t unnecessary, though. Before this, we invoke
bdrv_dirty_bitmap_create_successor(), so the error path has to clean
that up with bdrv_reclaim_dirty_bitmap().
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-04-26 18:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 14:49 [Qemu-devel] [PATCH v6 0/5] backup-top: preparing refactoring Vladimir Sementsov-Ogievskiy
2019-04-15 14:49 ` Vladimir Sementsov-Ogievskiy
2019-04-15 14:49 ` [Qemu-devel] [PATCH v6 1/5] block/backup: simplify backup_incremental_init_copy_bitmap Vladimir Sementsov-Ogievskiy
2019-04-15 14:49 ` Vladimir Sementsov-Ogievskiy
2019-04-26 17:44 ` Max Reitz
2019-04-26 17:44 ` Max Reitz
2019-04-15 14:49 ` [Qemu-devel] [PATCH v6 2/5] block/backup: move to copy_bitmap with granularity Vladimir Sementsov-Ogievskiy
2019-04-15 14:49 ` Vladimir Sementsov-Ogievskiy
2019-04-15 14:49 ` [Qemu-devel] [PATCH v6 3/5] block/backup: refactor and tolerate unallocated cluster skipping Vladimir Sementsov-Ogievskiy
2019-04-15 14:49 ` Vladimir Sementsov-Ogievskiy
2019-04-26 18:04 ` Max Reitz
2019-04-26 18:04 ` Max Reitz
2019-04-15 14:49 ` [Qemu-devel] [PATCH v6 4/5] block/backup: unify different modes code path Vladimir Sementsov-Ogievskiy
2019-04-15 14:49 ` Vladimir Sementsov-Ogievskiy
2019-04-26 18:18 ` Max Reitz
2019-04-26 18:18 ` Max Reitz
2019-04-15 14:49 ` [Qemu-devel] [PATCH v6 5/5] block/backup: refactor: split out backup_calculate_cluster_size Vladimir Sementsov-Ogievskiy
2019-04-15 14:49 ` Vladimir Sementsov-Ogievskiy
2019-04-26 18:30 ` Max Reitz [this message]
2019-04-26 18:30 ` Max Reitz
2019-04-29 4:49 ` Vladimir Sementsov-Ogievskiy
2019-04-29 4:49 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f5ed0c3-83d0-bcbe-5866-e0aab67f188f@redhat.com \
--to=mreitz@redhat.com \
--cc=den@openvz.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).