qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Taylor Simpson <tsimpson@quicinc.com>,
	Peter Maydell <peter.maydell@linaro.org>
Cc: "open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [PULL 1/4] Hexagon (target/hexagon) fix bug in fLSBNEW*
Date: Fri, 18 Jun 2021 09:08:06 +0200	[thread overview]
Message-ID: <4f68879e-d210-1153-a2bc-5b11e6ec3a35@redhat.com> (raw)
In-Reply-To: <1623966755-30225-2-git-send-email-tsimpson@quicinc.com>

On 17/06/2021 23.52, Taylor Simpson wrote:
> Change fLSBNEW/fLSBNEW0/fLSBNEW1 from copy to "x & 1"
> Remove gen_logical_not function
> Clean up fLSBNEWNOT to use andi-1 followed by xori-1
> 
> Test cases added to tests/tcg/hexagon/misc.c
> 
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
>   target/hexagon/macros.h    | 27 ++++++++++-----------------
>   target/hexagon/op_helper.c |  5 -----
>   tests/tcg/hexagon/misc.c   | 39 ++++++++++++++++++++++++++++++++++++++-
>   3 files changed, 48 insertions(+), 23 deletions(-)

  Hi!

Looks like you've missed to add a cover letter with the PULL information to 
this series (at least I did not receive one and the archive on 
https://lists.gnu.org/archive/html/qemu-devel/2021-06/threads.html doesn't 
show it either)... I guess Peter won't be able to process this PULL request 
that way, so please send again with a proper cover letter added.

  Thomas



  reply	other threads:[~2021-06-18  7:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1623966755-30225-1-git-send-email-tsimpson@quicinc.com>
2021-06-17 21:52 ` [PULL 1/4] Hexagon (target/hexagon) fix bug in fLSBNEW* Taylor Simpson
2021-06-18  7:08   ` Thomas Huth [this message]
2021-06-17 21:52 ` [PULL 2/4] Hexagon (target/hexagon) fix l2fetch instructions Taylor Simpson
2021-06-17 21:52 ` [PULL 3/4] Hexagon (target/hexagon) cleanup gen_store_conditional[48] functions Taylor Simpson
2021-06-17 21:52 ` [PULL 4/4] Hexagon (target/hexagon) remove unused TCG variables Taylor Simpson
2021-06-18 19:06 [PULL 0/4] Hexagon (target/hexagon) bug fixes Taylor Simpson
2021-06-18 19:06 ` [PULL 1/4] Hexagon (target/hexagon) fix bug in fLSBNEW* Taylor Simpson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4f68879e-d210-1153-a2bc-5b11e6ec3a35@redhat.com \
    --to=thuth@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=tsimpson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).