From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63B9FC433B4 for ; Thu, 8 Apr 2021 19:24:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0532C610E6 for ; Thu, 8 Apr 2021 19:24:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0532C610E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53482 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lUaGB-0002pp-Qn for qemu-devel@archiver.kernel.org; Thu, 08 Apr 2021 15:24:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36000) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lUaFP-0002Gx-6I for qemu-devel@nongnu.org; Thu, 08 Apr 2021 15:23:23 -0400 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]:37705) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lUaFM-0004vl-Hl for qemu-devel@nongnu.org; Thu, 08 Apr 2021 15:23:22 -0400 Received: by mail-pg1-x529.google.com with SMTP id k8so2105753pgf.4 for ; Thu, 08 Apr 2021 12:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Uv0jAg1tex/p6P52G9UO0FeW+GxnDqjF3l5/qEkB0Es=; b=FIXQqvf1o//ifYDPraIsKt7n6mzusdJKsUdFEOxUnUsRhGcNH5D52KBHv6FOEi9+bJ 1DYzACZCC635D6yQ/MdICiKu+lzKvY52FZpWneifW8xqPHRrroU92T3wMD1wWatJ0aPF /GP/Xm2hHApiPgVfWK6S7TOdGrpF7UWIPUE7eYOJgV3l1tWewregSqdBQALaxDWtYV85 Rphq7fQ6B8vgSUSTTZTsPGMrbnUwlcaJjup+hTra00/32HraES4nsMsXyJaDmYWDfFJT /49TWxDiwjLmUAoO0t8f+vbnVjAsFfjwEARq1Lub95DXXAid9Bf1rgGAiZRKFNL0gxb6 PUaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Uv0jAg1tex/p6P52G9UO0FeW+GxnDqjF3l5/qEkB0Es=; b=qxKXTdtACl7gZPxgVJVwuoMLthz+K1r8/fbQi6+ZiUevaZiaRXZfiN/0p7s0GYHVL0 8xCDrAboOB1V7UABcv24867E4lru5M/rq3v3kkkLWrcj1mkWiiF96hx8IIUvWwwDYf49 Wz9n585jrfO6raiOURXfu0gAmn0wuu8pbPJAte2QA86FemW1bpOXdayjjevRTxh1ZhRK R+0HqgsPjedja2CV184UWcmHkiTr2iiey9hKGo8XiX41s8C3cC9IOb9kLw/cRLvRb9MK Q6x0CfE4MD4dV7nydGNlH5t02ah1KFXvCjpD7E+f4I7LxV4lQZv7tN6m+ve7mpd+WlUq qlrA== X-Gm-Message-State: AOAM532AstY2p11Xdq9GlafK7lcrsrqgkvn+f/BQegLc2q0nLS73Y7Um 5HrQTth5zPE5UM1lv9kDC9aWAg== X-Google-Smtp-Source: ABdhPJyJCqlo7QS8EWqU7ETCO9XJWRMO0vpVpQ6/f2SxHs535j7AhroU3nHBItNOVTS5YCrzwewFAA== X-Received: by 2002:a65:4582:: with SMTP id o2mr9618769pgq.93.1617909798971; Thu, 08 Apr 2021 12:23:18 -0700 (PDT) Received: from [192.168.1.11] ([71.212.131.83]) by smtp.gmail.com with ESMTPSA id gz12sm175828pjb.33.2021.04.08.12.23.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Apr 2021 12:23:18 -0700 (PDT) Subject: Re: [PATCH v3 16/26] Hexagon (target/hexagon) compile all debug code To: Taylor Simpson , qemu-devel@nongnu.org References: <1617847067-9867-1-git-send-email-tsimpson@quicinc.com> <1617847067-9867-17-git-send-email-tsimpson@quicinc.com> From: Richard Henderson Message-ID: <4f73f85c-a916-4a82-8e74-110679bd8c37@linaro.org> Date: Thu, 8 Apr 2021 12:23:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1617847067-9867-17-git-send-email-tsimpson@quicinc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ale@rev.ng, bcain@quicinc.com, philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 4/7/21 6:57 PM, Taylor Simpson wrote: > Change #if HEX_DEBUG to if (HEX_DEBUG) so that the debug code doesn't > bit rot. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Taylor Simpson > --- > target/hexagon/genptr.c | 72 ++++++++++++++++++++++---------------------- > target/hexagon/helper.h | 2 -- > target/hexagon/internal.h | 11 +++---- > target/hexagon/op_helper.c | 14 +++------ > target/hexagon/translate.c | 74 ++++++++++++++++++++++------------------------ > target/hexagon/translate.h | 2 -- > 6 files changed, 81 insertions(+), 94 deletions(-) Reviewed-by: Richard Henderson r~