From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1A6C4363D for ; Fri, 25 Sep 2020 16:04:07 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB69220759 for ; Fri, 25 Sep 2020 16:04:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hySQGyAS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB69220759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLqCb-0007YV-Im for qemu-devel@archiver.kernel.org; Fri, 25 Sep 2020 12:04:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLpqY-0003Up-Pb for qemu-devel@nongnu.org; Fri, 25 Sep 2020 11:41:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kLpqV-0007mV-SX for qemu-devel@nongnu.org; Fri, 25 Sep 2020 11:41:18 -0400 Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601048470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QJb9Tg2lFdosXaJfa0yJ1a4Cb76DC1SSNQ0tdLZBAdo=; b=hySQGyASIsTOvCku956jSgjHiSGl75Jr1WHRGUSjOvjqm9g4tEdKIwSWIGPQYI7HzLpS09 FJ26fLb23xwQf1IIJIUgn8qb/SiZKS277vn/n/DMnvaXsLAVDw+JdOu2zJO3vLkSXsNnVo g6206hpVpf+0/r54lpf/Q/YAR3rGH3g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-51-oFm1JOp7OiudmbCnIl59oA-1; Fri, 25 Sep 2020 11:41:09 -0400 X-MC-Unique: oFm1JOp7OiudmbCnIl59oA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B3F261084D74; Fri, 25 Sep 2020 15:41:07 +0000 (UTC) Received: from [10.10.119.140] (ovpn-119-140.rdu2.redhat.com [10.10.119.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id 017B15C1C2; Fri, 25 Sep 2020 15:41:06 +0000 (UTC) Subject: Re: [PATCH v2 09/38] qapi/common.py: Add indent manager To: Markus Armbruster References: <20200922210101.4081073-1-jsnow@redhat.com> <20200922210101.4081073-10-jsnow@redhat.com> <20200923145530.GI191229@localhost.localdomain> <50d8aa85-665e-5dd1-43d3-aeef1817df73@redhat.com> <87o8lut6jp.fsf@dusky.pond.sub.org> From: John Snow Message-ID: <4f7f5cd8-fea5-4158-5a66-5873b871012f@redhat.com> Date: Fri, 25 Sep 2020 11:41:06 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <87o8lut6jp.fsf@dusky.pond.sub.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/25 02:48:20 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.199, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.238, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Michael Roth , qemu-devel@nongnu.org, Cleber Rosa , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/25/20 7:55 AM, Markus Armbruster wrote: > John Snow writes: > >> On 9/23/20 10:55 AM, Cleber Rosa wrote: >>> Do you have a use case for returning the level? If not, I'd go >>> without it, and add a "level" property instead, as it'd serve more >>> cases. >> >> __int__ is doing that lifting. I can remove the return. > > I like my functions to return something useful. > > Use your judgement. > > Eh, Cleber had a point. Nothing uses it. (AKA: I already made the edit ...) Like you say, we'll figure out the truly beautiful way to do code generation when we tackle this all together, holistically. What I've got works for now (and isn't terribly complex), let's just roll with it while we fry the bigger fish. --js