From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: Jared Mauch <jared+home@puck.nether.net>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, devel@lists.libvirt.org
Subject: Re: [PATCH 4/7] hw/arm/raspi4b: Rename as raspi4b-1g / raspi4b-2g, deprecating old name
Date: Sat, 1 Feb 2025 15:30:11 +0100 [thread overview]
Message-ID: <4f8886c6-32f8-465b-a243-b5fa510a8f9f@linaro.org> (raw)
In-Reply-To: <20250201091528.1177-5-philmd@linaro.org>
On 1/2/25 10:15, Philippe Mathieu-Daudé wrote:
> On 32-bit hosts, rename 'raspi4b' -> 'raspi4b-1g' to clarify the
> machine has 1GB of RAM.
> On 64-bit hosts, rename 'raspi4b' -> 'raspi4b-2g'.
> Keep the 'raspi4b' alias but deprecate it.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> docs/about/deprecated.rst | 6 ++++++
> hw/arm/raspi4b.c | 6 ++++--
> 2 files changed, 10 insertions(+), 2 deletions(-)
> static const TypeInfo raspi4_machine_types[] = {
> #if HOST_LONG_BITS == 32
> {
> - .name = MACHINE_TYPE_NAME("raspi4b"),
> + .name = MACHINE_TYPE_NAME("raspi4b-1g"),
> .parent = TYPE_RASPI4_MACHINE,
> .class_init = raspi4b_1g_machine_class_init,
> },
> #else
> {
> - .name = MACHINE_TYPE_NAME("raspi4b"),
> + .name = MACHINE_TYPE_NAME("raspi4b-2g"),
> .parent = TYPE_RASPI4_MACHINE,
> .class_init = raspi4b_2g_machine_class_init,
> },
Forgot to squash here:
-- >8 --
diff --git a/tests/functional/test_aarch64_raspi4.py
b/tests/functional/test_aarch64_raspi4.py
index 7a4302b0c5a..891a8135b6b 100755
--- a/tests/functional/test_aarch64_raspi4.py
+++ b/tests/functional/test_aarch64_raspi4.py
@@ -37 +37 @@ def test_arm_raspi4(self):
- self.set_machine('raspi4b')
+ self.set_machine('raspi4b-1g')
@@ -67 +67 @@ def test_arm_raspi4_initrd(self):
- self.set_machine('raspi4b')
+ self.set_machine('raspi4b-1g')
---
next prev parent reply other threads:[~2025-02-01 14:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-01 9:15 [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM Philippe Mathieu-Daudé
2025-02-01 9:15 ` [PATCH 1/7] hw/arm/raspi4b: Declare machine types using DEFINE_TYPES() macro Philippe Mathieu-Daudé
2025-02-01 9:15 ` [PATCH 2/7] hw/arm/raspi4b: Introduce abstract raspi4-base machine type Philippe Mathieu-Daudé
2025-02-01 9:15 ` [PATCH 3/7] hw/arm/raspi4b: Split raspi4b_machine_class_init() in two (1g and 2g) Philippe Mathieu-Daudé
2025-02-01 9:15 ` [PATCH 4/7] hw/arm/raspi4b: Rename as raspi4b-1g / raspi4b-2g, deprecating old name Philippe Mathieu-Daudé
2025-02-01 14:30 ` Philippe Mathieu-Daudé [this message]
2025-02-01 9:15 ` [PATCH 5/7] hw/arm/raspi4b: Expose the raspi4b-1g machine on 64-bit hosts Philippe Mathieu-Daudé
2025-02-01 9:15 ` [PATCH 6/7] hw/arm/raspi4b: Add the raspi4b-4g machine Philippe Mathieu-Daudé
2025-02-01 9:15 ` [PATCH 7/7] hw/arm/raspi4b: Add the raspi4b-8g machine Philippe Mathieu-Daudé
2025-02-01 12:57 ` [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM BALATON Zoltan
2025-02-01 13:51 ` Peter Maydell
2025-02-03 14:29 ` Alex Bennée
2025-02-03 14:33 ` Daniel P. Berrangé
2025-02-03 14:45 ` Peter Maydell
2025-02-03 14:50 ` Daniel P. Berrangé
2025-02-03 15:05 ` Peter Maydell
2025-02-03 16:19 ` Philippe Mathieu-Daudé
2025-02-03 23:20 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f8886c6-32f8-465b-a243-b5fa510a8f9f@linaro.org \
--to=philmd@linaro.org \
--cc=devel@lists.libvirt.org \
--cc=jared+home@puck.nether.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).