From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>,
Yaowei Bai <baiyaowei@cmss.chinamobile.com>
Cc: "Emilio G. Cota" <cota@braap.org>,
qemu-trivial@nongnu.org, mjt@tls.msk.ru, laurent@vivier.eu,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tracing.txt: add missing '-' for trace option
Date: Mon, 18 Jun 2018 17:11:16 -0500 [thread overview]
Message-ID: <4fb174ba-ec91-483e-63ed-ca3c118ae9f8@redhat.com> (raw)
In-Reply-To: <20180615173013.GH12972@stefanha-x1.localdomain>
On 06/15/2018 12:30 PM, Stefan Hajnoczi wrote:
>>>
>>> So I'm in favor of this patch, although it may need more of a commit
>>> message summarizing the justification I've just pointed you to.
>>
>> Thanks for your nice explaination. If this patch could be merged i will
>> send V2 with a commit message.
>
> Please update the remaining occurrences of the -trace option syntax in
> v2:
>
> $ git grep -- -trace docs/devel/tracing.txt
Also fixing strings in trace/control.[ch] would be appropriate.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2018-06-18 22:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-13 3:15 [Qemu-devel] [PATCH] tracing.txt: add missing '-' for trace option Yaowei Bai
2018-06-13 3:50 ` Emilio G. Cota
2018-06-13 8:44 ` Yaowei Bai
2018-06-13 11:27 ` Eric Blake
2018-06-13 14:15 ` Yaowei Bai
2018-06-15 17:30 ` Stefan Hajnoczi
2018-06-18 22:11 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fb174ba-ec91-483e-63ed-ca3c118ae9f8@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=cota@braap.org \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).