From: Richard Henderson <richard.henderson@linaro.org>
To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
Kito Cheng <kito.cheng@sifive.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>
Subject: Re: [RFC v2 07/15] target/riscv: rvb: sign-extend instructions
Date: Wed, 16 Dec 2020 10:25:11 -0600 [thread overview]
Message-ID: <4fbcfe60-6bad-02cc-27dc-a354794aaec7@linaro.org> (raw)
In-Reply-To: <20201216020150.3157-8-frank.chang@sifive.com>
On 12/15/20 8:01 PM, frank.chang@sifive.com wrote:
> +static bool trans_sext_h(DisasContext *ctx, arg_sext_h *a)
> +{
> + REQUIRE_EXT(ctx, RVB);
> + return gen_unary(ctx, a, &tcg_gen_ext16s_tl);
> +}
> +
> +{
Stray "{".
Presumably a rebase error fixed up in a later patch?
Anyway, with that fixed,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-12-16 16:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 2:01 [RFC v2 00/15] support subsets of bitmanip extension frank.chang
2020-12-16 2:01 ` [RFC v2 01/15] target/riscv: reformat @sh format encoding for B-extension frank.chang
2020-12-16 15:15 ` Richard Henderson
2020-12-16 2:01 ` [RFC v2 02/15] target/riscv: rvb: count leading/trailing zeros frank.chang
2020-12-16 15:21 ` Richard Henderson
2020-12-16 2:01 ` [RFC v2 03/15] target/riscv: rvb: count bits set frank.chang
2020-12-16 15:24 ` Richard Henderson
2020-12-16 2:01 ` [RFC v2 04/15] target/riscv: rvb: logic-with-negate frank.chang
2020-12-16 15:25 ` Richard Henderson
2020-12-16 2:01 ` [RFC v2 05/15] target/riscv: rvb: pack two words into one register frank.chang
2020-12-16 16:23 ` Richard Henderson
2020-12-16 2:01 ` [RFC v2 06/15] target/riscv: rvb: min/max instructions frank.chang
2020-12-16 16:23 ` Richard Henderson
2020-12-16 2:01 ` [RFC v2 07/15] target/riscv: rvb: sign-extend instructions frank.chang
2020-12-16 16:25 ` Richard Henderson [this message]
2020-12-16 2:01 ` [RFC v2 08/15] target/riscv: rvb: single-bit instructions frank.chang
2020-12-16 16:34 ` Richard Henderson
2020-12-16 2:01 ` [RFC v2 09/15] target/riscv: rvb: shift ones frank.chang
2020-12-16 16:35 ` Richard Henderson
2020-12-16 2:01 ` [RFC v2 10/15] target/riscv: rvb: rotate (left/right) frank.chang
2020-12-16 16:39 ` Richard Henderson
2020-12-16 2:01 ` [RFC v2 11/15] target/riscv: rvb: generalized reverse frank.chang
2020-12-16 16:52 ` Richard Henderson
2020-12-16 2:01 ` [RFC v2 12/15] target/riscv: rvb: generalized or-combine frank.chang
2020-12-16 18:15 ` Richard Henderson
2020-12-16 2:01 ` [RFC v2 13/15] target/riscv: rvb: address calculation frank.chang
2020-12-16 18:17 ` Richard Henderson
2020-12-16 2:01 ` [RFC v2 14/15] target/riscv: rvb: add/sub with postfix zero-extend frank.chang
2020-12-16 18:30 ` Richard Henderson
2020-12-16 2:01 ` [RFC v2 15/15] target/riscv: rvb: support and turn on B-extension from command line frank.chang
2020-12-16 9:14 ` Kito Cheng
2020-12-16 18:31 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fbcfe60-6bad-02cc-27dc-a354794aaec7@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=frank.chang@sifive.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kito.cheng@sifive.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).