From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDBCCC4361B for ; Wed, 16 Dec 2020 16:27:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31487233F6 for ; Wed, 16 Dec 2020 16:27:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31487233F6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpZdv-0002aS-7P for qemu-devel@archiver.kernel.org; Wed, 16 Dec 2020 11:27:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60606) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpZcB-0000C1-VC for qemu-devel@nongnu.org; Wed, 16 Dec 2020 11:25:23 -0500 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:42573) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kpZc9-0007Cv-U4 for qemu-devel@nongnu.org; Wed, 16 Dec 2020 11:25:23 -0500 Received: by mail-pl1-x62e.google.com with SMTP id s2so13205853plr.9 for ; Wed, 16 Dec 2020 08:25:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kaJVsuiZGLpTpUX6LevuWpLqM5gPjTgFJgdqWdpdES8=; b=UiL4ENjkCuK+1OYS1gpxDbo0zjvD9j7DvNUNj38CiGvDD3+Ggm0EgYdlzAbGnKpGl7 ocooWwcajtuR6TkRq+klIu1H+n4ys4HlX/Qz7u7egk6DlhHi0B4yLCXejVkQDm1XmhxX QASEJKlEVyDXJpfhhM4TkDXyZkEa+YyK3cSmKji0+L5AiQbC/cTgEzm1IfRHxJkR9Cjs tSLir5/oKHn9MhlKfXgr5K/H7U0bu7Gn8PI6ejfQhLGIBi3iCvBtV+M6/KJ9gBSlZNPC dw1WzjNV2zdZ9D6+30NMCfuvWpieBOap7IpOrVJTkJ5jF60ZnBbKKXgyJwam++jIhrvR YVbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kaJVsuiZGLpTpUX6LevuWpLqM5gPjTgFJgdqWdpdES8=; b=GMVC8HZtHmq1+lRHJumdFhot9uGQGdqhZM2l2NS0x+1FbUa6QouN6zVO+rNcRCmuRH dKOI/U15aFNJh6S7ZvkBs8FUG4obuL9fZKAkky0Jv/IJL04rDxEVzQ+RT+1GiFUUBhV1 ysuiyQYB+jje8g7RXvwbmbQ1ERcI+HcXcU4jExbk0vDLclPwL1KY7vTMKBP9xQXIgw+S RdKQdyBiTesoHzV/wh3LNf7Moz+NMpOJXcRdiuSGwjV6L/MIxh6NJ6iPvG7Fct9xspUz yLPmGcUW8+AlOBTlVdQbEzR3bwI16ImioJMii/E+R4n1FIKoxS0J3ymrdtV8wHniNeWA FQ6Q== X-Gm-Message-State: AOAM533Dt599UWqguRagknzMERCBsK6+eL9RWghQtVoqQwTlsOhPByhZ BTJyV/x3XYpczFHsBKnlU8Ucaw== X-Google-Smtp-Source: ABdhPJxbR1UTyC98l+EQIBSArhFIilUzQPdS4FUGApFAb830/74kaksPgmdMCoanwnhDVsaA0AVa7A== X-Received: by 2002:a17:90b:3110:: with SMTP id gc16mr3746639pjb.83.1608135919793; Wed, 16 Dec 2020 08:25:19 -0800 (PST) Received: from [192.168.71.34] ([172.58.27.195]) by smtp.gmail.com with ESMTPSA id s5sm2549219pju.9.2020.12.16.08.25.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Dec 2020 08:25:18 -0800 (PST) Subject: Re: [RFC v2 07/15] target/riscv: rvb: sign-extend instructions To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20201216020150.3157-1-frank.chang@sifive.com> <20201216020150.3157-8-frank.chang@sifive.com> From: Richard Henderson Message-ID: <4fbcfe60-6bad-02cc-27dc-a354794aaec7@linaro.org> Date: Wed, 16 Dec 2020 10:25:11 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201216020150.3157-8-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bastian Koppelmann , Kito Cheng , Alistair Francis , Palmer Dabbelt , Sagar Karandikar Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 12/15/20 8:01 PM, frank.chang@sifive.com wrote: > +static bool trans_sext_h(DisasContext *ctx, arg_sext_h *a) > +{ > + REQUIRE_EXT(ctx, RVB); > + return gen_unary(ctx, a, &tcg_gen_ext16s_tl); > +} > + > +{ Stray "{". Presumably a rebase error fixed up in a later patch? Anyway, with that fixed, Reviewed-by: Richard Henderson r~