From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38254) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwrLy-0002Eq-4P for qemu-devel@nongnu.org; Wed, 19 Oct 2016 09:56:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwrLu-0003qE-8i for qemu-devel@nongnu.org; Wed, 19 Oct 2016 09:56:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47734) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwrLu-0003oT-0j for qemu-devel@nongnu.org; Wed, 19 Oct 2016 09:56:18 -0400 References: <1259cdba-c137-c3da-abe2-ecf51aec6738@linux.intel.com> <523e1446-75f1-fe3a-d818-f7d238d57751@redhat.com> <5800B579.9000705@intel.com> <20161014084158.623087aa@t450s.home> <20161014084601.2a50ba87@t450s.home> <20161014163545.GA6121@nvidia.com> <20161014105124.42b438a6@t450s.home> <20161014221901.GA8865@nvidia.com> <20161017100229.1474ae33@t450s.home> <580617BD.8000300@intel.com> <20161018085918.61ec0e93@t450s.home> <5806DB2D.6090306@intel.com> From: Eric Blake Message-ID: <4fe2a0be-a632-8c74-241f-66e51b6d7fd5@redhat.com> Date: Wed, 19 Oct 2016 08:56:15 -0500 MIME-Version: 1.0 In-Reply-To: <5806DB2D.6090306@intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nO2CeH0DTaNgBmaMH8AX0kxbLoMQ7jIMx" Subject: Re: [Qemu-devel] [PATCH 1/2] KVM: page track: add a new notifier type: track_flush_slot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jike Song , Alex Williamson Cc: "Tian, Kevin" , Xiao Guangrong , kvm@vger.kernel.org, guangrong.xiao@intel.com, qemu-devel , Xiaoguang Chen , Kirti Wankhede , Paolo Bonzini , Neo Jia This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nO2CeH0DTaNgBmaMH8AX0kxbLoMQ7jIMx From: Eric Blake To: Jike Song , Alex Williamson Cc: "Tian, Kevin" , Xiao Guangrong , kvm@vger.kernel.org, guangrong.xiao@intel.com, qemu-devel , Xiaoguang Chen , Kirti Wankhede , Paolo Bonzini , Neo Jia Message-ID: <4fe2a0be-a632-8c74-241f-66e51b6d7fd5@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/2] KVM: page track: add a new notifier type: track_flush_slot References: <1259cdba-c137-c3da-abe2-ecf51aec6738@linux.intel.com> <523e1446-75f1-fe3a-d818-f7d238d57751@redhat.com> <5800B579.9000705@intel.com> <20161014084158.623087aa@t450s.home> <20161014084601.2a50ba87@t450s.home> <20161014163545.GA6121@nvidia.com> <20161014105124.42b438a6@t450s.home> <20161014221901.GA8865@nvidia.com> <20161017100229.1474ae33@t450s.home> <580617BD.8000300@intel.com> <20161018085918.61ec0e93@t450s.home> <5806DB2D.6090306@intel.com> In-Reply-To: <5806DB2D.6090306@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [meta-comment] On 10/18/2016 09:32 PM, Jike Song wrote: > On 10/18/2016 10:59 PM, Alex Williamson wrote: =2E.. >>>>>>>>>>>>>>> On 10/10/2016 20:01, Neo Jia wrote: =20 >>>>>>>>>>>>>>>>> Hi Neo, 17 levels of quoting is rather over-the-top. It is OKAY (and in fact DESIRABLE) to trim your emails to relevant portions, when posting to a high-volume list. Readers shouldn't have to scroll through pages of deeply-nested quoting... >>> =20 >>> mutex_lock(&vfio.group_lock); >>> list_for_each_entry(group, &vfio.group_list, vfio_next) { >>> if (group->iommu_group =3D=3D iommu_group) { >>> - vfio_group_get(group); >> >> This is wrong, we can't add our reference after we release the lock. >> >=20 > Thanks for pointing it out :) >=20 =2E..to get to the much smaller meat of the message. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nO2CeH0DTaNgBmaMH8AX0kxbLoMQ7jIMx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYB3t/AAoJEKeha0olJ0Nq/NEH/ilmL6ESaqd2RegDnMWSZwGh xE2QkI2G1EhWnW3ENGHMKVENriHFGp9MvcywCwgYZU1RSm3Xk2ItDTylZeepw0BG wl3fLhFgUez8JSTtqGGpel2muVzCGgqIwRt50jkceLa4jNg3m9x5gdJ5lwixeozD cnpXmJoutGrXpj3x+xS60XMen2lrUtLTngbfsYLIpL+RU4Vu3tOckir5dSzrK4xM RwbMvetPyyHqsuccBlhY181AI4PScOOBnZIhC7kqig/JMowtfhU7TPDfccIKg3V2 0uF7ncRCqWi48XJtFV/UwPscd9QsOCz+LXhUK9gvjIBBFPeZHkbyb/CNlPXNywg= =T9p1 -----END PGP SIGNATURE----- --nO2CeH0DTaNgBmaMH8AX0kxbLoMQ7jIMx--