From: Hanna Reitz <hreitz@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-block@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] tests/qemu-iotests/testrunner: Quote "case not run" lines in TAP mode
Date: Thu, 24 Feb 2022 17:56:12 +0100 [thread overview]
Message-ID: <4ff2d2ec-dce9-2675-345e-fbb400ecb1b9@redhat.com> (raw)
In-Reply-To: <20220223124353.3273898-1-thuth@redhat.com>
On 23.02.22 13:43, Thomas Huth wrote:
> In TAP mode, the stdout is reserved for the TAP protocol, so we
> have to make sure to mark other lines with a comment '#' character
> at the beginning to avoid that the TAP parser at the other end
> gets confused.
>
> To test this condition, run "configure" for example with:
>
> --block-drv-rw-whitelist=copy-before-write,qcow2,raw,file,host_device,blkdebug,null-co,copy-on-read
>
> so that iotest 041 will report that some tests are not run due to
> the missing "quorum" driver. Without this change, "make check-block"
> fails since the meson tap parser gets confused by these messages.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/testrunner.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
Thanks, applied to my block branch:
https://gitlab.com/hreitz/qemu/-/commits/block
Hanna
prev parent reply other threads:[~2022-02-24 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 12:43 [PATCH] tests/qemu-iotests/testrunner: Quote "case not run" lines in TAP mode Thomas Huth
2022-02-24 16:56 ` Hanna Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ff2d2ec-dce9-2675-345e-fbb400ecb1b9@redhat.com \
--to=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).