From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Stefano Garzarella <sgarzare@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mst@redhat.com, lulu@redhat.com,
eperezma@redhat.com, Jason Wang <jasowang@redhat.com>
Subject: Re: [PATCH for-9.0 v2] vhost-vdpa: check vhost_vdpa_set_vring_ready() return value
Date: Fri, 22 Mar 2024 16:01:38 +0100 [thread overview]
Message-ID: <4ffb9edb-f4c3-4775-b05e-00d233ca2e65@linaro.org> (raw)
In-Reply-To: <20240322092315.31885-1-sgarzare@redhat.com>
On 22/3/24 10:23, Stefano Garzarella wrote:
> vhost_vdpa_set_vring_ready() could already fail, but if Linux's
> patch [1] will be merged, it may fail with more chance if
> userspace does not activate virtqueues before DRIVER_OK when
> VHOST_BACKEND_F_ENABLE_AFTER_DRIVER_OK is not negotiated.
>
> So better check its return value anyway.
>
> [1] https://lore.kernel.org/virtualization/20240206145154.118044-1-sgarzare@redhat.com/T/#u
>
> Acked-by: Eugenio Pérez <eperezma@redhat.com>
> Acked-by: Jason Wang <jasowang@redhat.com>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
> Based-on: 20240315155949.86066-1-kwolf@redhat.com
>
> v1: https://patchew.org/QEMU/20240207092702.25242-1-sgarzare@redhat.com/
> v2:
> - added acks
> - rebased on top of https://patchew.org/QEMU/20240315155949.86066-1-kwolf@redhat.com/
> ---
> net/vhost-vdpa.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2024-03-22 15:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 9:23 [PATCH for-9.0 v2] vhost-vdpa: check vhost_vdpa_set_vring_ready() return value Stefano Garzarella
2024-03-22 15:01 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ffb9edb-f4c3-4775-b05e-00d233ca2e65@linaro.org \
--to=philmd@linaro.org \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).