From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56285) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqgMm-0003AT-9A for qemu-devel@nongnu.org; Mon, 16 Jul 2012 04:09:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqgMk-0004jA-P8 for qemu-devel@nongnu.org; Mon, 16 Jul 2012 04:09:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:25102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqgMk-0004ix-HT for qemu-devel@nongnu.org; Mon, 16 Jul 2012 04:09:14 -0400 Message-ID: <5003CC1D.50400@redhat.com> Date: Mon, 16 Jul 2012 11:09:01 +0300 From: Avi Kivity MIME-Version: 1.0 References: <878veoz5yv.fsf@rustcorp.com.au> <87pq7wxje8.fsf@rustcorp.com.au> In-Reply-To: <87pq7wxje8.fsf@rustcorp.com.au> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [kvmarm] [PATCH] target-arm: kvm: use KVM_SET_SREGS to set target to Cortex A15 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rusty Russell Cc: "qemu-devel@nongnu.org" , "peter.maydell@linaro.org" , Alexander Graf , "kvmarm@lists.cs.columbia.edu" On 07/16/2012 10:19 AM, Rusty Russell wrote: > On Fri, 13 Jul 2012 12:06:26 +0200, Alexander Graf wrote: >> > struct kvm_sregs { >> > + __u32 target; >> > + __u32 num_features; >> > + __u32 features[14]; >> > }; >> >> Are you sure you want to use sregs? We did the mistake of reusing it >> on ppc, but that doesn't mean you need to repeat the same one :) >> >> Basically sregs are an x86 specific struct for its segment register >> information. I'm quite sure that this is not what your use of them is >> here. > > Since each arch is given a hook already, I just abused it. I'll change > this to a fresh KVM_ARM_SET_TARGET ioctl. I guess this is equivalent to KVM_SET_CPUID2 on x86. Note that's a vcpu ioctl. -- error compiling committee.c: too many arguments to function