Re: [Qemu-devel] [RFC PATCH 3/4] qapi: Convert delvm

[Pavel Hrdina <phrdina@redhat.com>]

On 07/12/2012 07:59 PM, Eric Blake wrote:
> On 07/12/2012 10:55 AM, Pavel Hrdina wrote:
>> Signed-off-by: Pavel Hrdina<phrdina@redhat.com>
>> ---
>>   hmp-commands.hx  |    2 +-
>>   hmp.c            |   10 ++++++++++
>>   hmp.h            |    1 +
>>   qapi-schema.json |   17 +++++++++++++++++
>>   qmp-commands.hx  |   24 ++++++++++++++++++++++++
>>   savevm.c         |   21 +++++++++++----------
>>   sysemu.h         |    1 -
>>   7 files changed, 64 insertions(+), 12 deletions(-)
>> +
>> +##
>> +# @delvm:
> This name is worse than 'loadvm' or 'savevm', in that we are NOT
> deleting the entire vm, but a named snapshot stored within the vm.
> Would naming it 'delete-vm-snapshot' make more sense (in which case the
> others might make more sense as 'save-vm-snapshot' and 'load-vm-snapshot')?
>
This naming looks nice. I definitely agree that it could be 
save-vm-snapshot, load-vm-snapshot, delete-vm-snapshot and 
query-vm-snapshots.

Pavel