Re: [Qemu-devel] [RFC PATCH 4/4] qapi: Convert info snapshots

[Pavel Hrdina <phrdina@redhat.com>]

On 07/12/2012 08:03 PM, Eric Blake wrote:
> On 07/12/2012 10:55 AM, Pavel Hrdina wrote:
>> Signed-off-by: Pavel Hrdina<phrdina@redhat.com>
>> ---
>> +++ b/qapi-schema.json
>> @@ -934,6 +934,41 @@
>>   { 'command': 'query-block-jobs', 'returns': ['BlockJobInfo'] }
>>   
>>   ##
>> +# @SnapshotInfo:
>> +#
>> +# Snapshot list.  This structure contains list of snapshots for virtual machine.
>> +#
>> +# @id: id of the snapshot.
>> +#
>> +# @tag: human readable tag of the snapshot.
> Tag was optional on creation, should that field be marked optional and
> omitted on output when there was no tag on input?
If you create snapshot using an ID, Tag is created automatically. Even 
if it is ugly tag, I think that we shouldn't omit it on output.
>> +#
>> +# @vm_size: size of the snapshot in Bytes.
>> +#
>> +# @date: date and time of the snapshot as timestamp.
> What type of timestamp?  Seconds since Epoch?
It is unix timestamp in seconds since Epoch.
>> +#
>> +# @vm_clock: time in the guest in nsecs.
> If vm_clock is in nsecs, should we also be reporting sub-second
> resolution in date?
Well, I thought that this could be enough, but we could return the same 
structure as "QEMUSnapshotInfo".
>> +SQMP
>> +query-snapshots
>> +----------
>> +
>> +List available snapshots for VM.
>> +
>> +Return a json-object with the following information:
> Returns an array of json-objects, each with the following information:
>