From: Kevin Wolf <kwolf@redhat.com>
To: Pavel Hrdina <phrdina@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/2] fdc: fix relative seek
Date: Mon, 16 Jul 2012 15:24:07 +0200 [thread overview]
Message-ID: <500415F7.1060806@redhat.com> (raw)
In-Reply-To: <9dc073c2eb42bb753565f23644bf449cb05ed4ed.1342440657.git.phrdina@redhat.com>
Am 16.07.2012 14:25, schrieb Pavel Hrdina:
> Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
> ---
> hw/fdc.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
I applied both to the block branch for now. This restores the behaviour
as it was before 6be01b1e. However, I believe it is still wrong: The
direction should be interpreted the other way round, i.e. seek_out
should decrease the cylinder number and seek_in should increase it.
Do you have a guest that actually uses this command?
Kevin
next prev parent reply other threads:[~2012-07-16 13:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1342440656.git.phrdina@redhat.com>
2012-07-16 12:25 ` [Qemu-devel] [PATCH v2 1/2] fdc: fix relative seek Pavel Hrdina
2012-07-16 13:24 ` Kevin Wolf [this message]
2012-07-16 13:26 ` Pavel Hrdina
2012-07-16 13:30 ` Pavel Hrdina
2012-07-16 12:25 ` [Qemu-devel] [PATCH v2 2/2] fdc-test: introduce test_relative_seek Pavel Hrdina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500415F7.1060806@redhat.com \
--to=kwolf@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).