From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqlHd-0004Kt-M9 for qemu-devel@nongnu.org; Mon, 16 Jul 2012 09:24:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqlHY-0001MK-1G for qemu-devel@nongnu.org; Mon, 16 Jul 2012 09:24:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:24276) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqlHX-0001ME-PK for qemu-devel@nongnu.org; Mon, 16 Jul 2012 09:24:11 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6GDOA2M017959 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Jul 2012 09:24:10 -0400 Message-ID: <500415F7.1060806@redhat.com> Date: Mon, 16 Jul 2012 15:24:07 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <9dc073c2eb42bb753565f23644bf449cb05ed4ed.1342440657.git.phrdina@redhat.com> In-Reply-To: <9dc073c2eb42bb753565f23644bf449cb05ed4ed.1342440657.git.phrdina@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] fdc: fix relative seek List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Hrdina Cc: qemu-devel@nongnu.org Am 16.07.2012 14:25, schrieb Pavel Hrdina: > Signed-off-by: Pavel Hrdina > --- > hw/fdc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) I applied both to the block branch for now. This restores the behaviour as it was before 6be01b1e. However, I believe it is still wrong: The direction should be interpreted the other way round, i.e. seek_out should decrease the cylinder number and seek_in should increase it. Do you have a guest that actually uses this command? Kevin