From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqlNo-0008Id-DY for qemu-devel@nongnu.org; Mon, 16 Jul 2012 09:30:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqlNh-0003Dy-Sv for qemu-devel@nongnu.org; Mon, 16 Jul 2012 09:30:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqlNh-0003BW-Kj for qemu-devel@nongnu.org; Mon, 16 Jul 2012 09:30:33 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6GDUWWc004516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Jul 2012 09:30:32 -0400 Message-ID: <50041776.6000807@redhat.com> Date: Mon, 16 Jul 2012 15:30:30 +0200 From: Pavel Hrdina MIME-Version: 1.0 References: <9dc073c2eb42bb753565f23644bf449cb05ed4ed.1342440657.git.phrdina@redhat.com> <500415F7.1060806@redhat.com> <5004166F.8030505@redhat.com> In-Reply-To: <5004166F.8030505@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/2] fdc: fix relative seek List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On 07/16/2012 03:26 PM, Pavel Hrdina wrote: > On 07/16/2012 03:24 PM, Kevin Wolf wrote: >> Am 16.07.2012 14:25, schrieb Pavel Hrdina: >>> Signed-off-by: Pavel Hrdina >>> --- >>> hw/fdc.c | 6 ++++-- >>> 1 file changed, 4 insertions(+), 2 deletions(-) >> I applied both to the block branch for now. This restores the behaviour >> as it was before 6be01b1e. However, I believe it is still wrong: The >> direction should be interpreted the other way round, i.e. seek_out >> should decrease the cylinder number and seek_in should increase it. >> >> Do you have a guest that actually uses this command? >> >> Kevin > I have host with real floppy device and I could send command directly, > so I'll check this behavior. > > Pavel Well, you're right... seek in increase track and seek out decrease track. I suspect that it was correct. I'll send v3 with this fix. Pavel