From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqmTH-0005Kf-5B for qemu-devel@nongnu.org; Mon, 16 Jul 2012 10:40:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqmT7-0007tK-Ko for qemu-devel@nongnu.org; Mon, 16 Jul 2012 10:40:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqmT7-0007tG-BH for qemu-devel@nongnu.org; Mon, 16 Jul 2012 10:40:13 -0400 Message-ID: <500427CA.2050200@redhat.com> Date: Mon, 16 Jul 2012 08:40:10 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig56D13C1B9926E6AEB549D7E7" Subject: Re: [Qemu-devel] [PATCH v3 1/2] bitops: drop volatile qualifier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig56D13C1B9926E6AEB549D7E7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 07/14/2012 06:34 AM, Blue Swirl wrote: > Qualifier 'volatile' is not useful for applications, it's too strict > for single threaded code but does not give the real atomicity guarantee= s > needed for multithreaded code. >=20 > Drop them and now useless casts. >=20 > -static inline void set_bit(int nr, volatile unsigned long *addr) > +static inline void set_bit(int nr, unsigned long *addr) > { > unsigned long mask =3D BIT_MASK(nr); > - unsigned long *p =3D ((unsigned long *)addr) + BIT_WORD(nr); > + unsigned long *p =3D addr + BIT_WORD(nr); The diff looks weird, because you are converting TAB to space on your affected lines but not cleaning up the neighboring lines. Is it worth a preliminary patch to whitespace-sanitize things? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig56D13C1B9926E6AEB549D7E7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQBCfLAAoJEKeha0olJ0NqybUH/i2Lgya1LOolSCroQ7/Mc4vX u5ey0N/+Q3XbRe06RSeVOKX0iQA1g3AW5/1J93yNt2Ee4j73DAkx2rB8+DXw7bOP HmbnoC1isYX+MgmHULwSkN/bk7L8J2+7WAWCwyyJsKD7ZcVsx/khLW/sch8+Oprx xi0Bbn1Qlbj9RbY7UzFWcbhC7j3oEfZeVxq275DE30QNcZGM+9UZHLdM8yZqhoI0 6a7nfp/VVJNygl7v1xVdZIJpPo8fIHZYXGcqpwiKqLmZgz3iBZ8JpB2jGHaMjJNC Sf/0h/ry7ynoWPSlJUyeQ1oeNfsJ2iWpd7AI52dZq0aHWo4libQ90K2jVZ3wGs0= =g6V+ -----END PGP SIGNATURE----- --------------enig56D13C1B9926E6AEB549D7E7--