From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqnOl-000320-LJ for qemu-devel@nongnu.org; Mon, 16 Jul 2012 11:39:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SqnOf-0000ew-PF for qemu-devel@nongnu.org; Mon, 16 Jul 2012 11:39:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SqnOf-0000eo-Fc for qemu-devel@nongnu.org; Mon, 16 Jul 2012 11:39:41 -0400 Message-ID: <500435B8.2010909@redhat.com> Date: Mon, 16 Jul 2012 09:39:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1342383972-11640-1-git-send-email-vapier@gentoo.org> <5003200B.4070400@weilnetz.de> In-Reply-To: <5003200B.4070400@weilnetz.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig35CBC88775E3A5ED872FBAB2" Subject: Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Mike Frysinger , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig35CBC88775E3A5ED872FBAB2 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 07/15/2012 01:54 PM, Stefan Weil wrote: > Am 15.07.2012 22:26, schrieb Mike Frysinger: >> We should not quote the PKG_CONFIG setting as this deviates from the >> canonical upstream behavior that gets integrated with all other build >> systems, and deviates from how we treat all other toolchain variables >> that we get from the environment. >> >> Ultimately, the point is that it breaks passing custom flags directly >> to pkg-config via the env var where this normally works elsewhere, >> and it used to work in the past. >=20 >=20 > What about passing custom flags with QEMU_PKG_CONFIG_FLAGS? >=20 > Removing the quotes will not allow paths containing spaces, > so that's not a good idea. Actually, it IS a good idea. The de facto standard build environment requires that pkg-config is not allowed to live in a path containing spaces, precisely so that you can override the variable to pass options to your preferred location of pkg-config; and if your build setup is truly so messed up as to have pkg-config installed in a canonical location with spaces, then you can also tweak your unusual environment to provide a symlink to pkg-config that does not contain spaces as the workaround. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig35CBC88775E3A5ED872FBAB2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJQBDW4AAoJEKeha0olJ0NqnnYIAK6I8+M4GtE2jWTCrPCLT4Eg HFrizyazrinM5/GHEDLn4AYvEqG+O+D7rLGr91ZwvyAxu14IC6V9BDora5U3o14b TQoabJNb3irCCQxgRWXRPiJ4kuMxgWSWGbSSbEog046YVmUVyU6wqaeLSfi7c/ee YaM9VoaAlKwAxWcKalj5upvGzIryUdcder8IaFkE6oZVyQuUoi3LdK2oylYdJhZS wCmjfoCdsW5pLlNCcmUAsXUGZQpJYVn+bZ8+RNCyFJy0nm1GYvvZzISogJ4N4Zvs pyiNcCSeggbdjgCqX8DSRBLos79+8jPdAH27zkjNUe4ngRFcuH92gZ6QOrqdc6w= =33a0 -----END PGP SIGNATURE----- --------------enig35CBC88775E3A5ED872FBAB2--